Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add linter commander to PR template #460

Merged
merged 1 commit into from
May 20, 2024
Merged

docs: add linter commander to PR template #460

merged 1 commit into from
May 20, 2024

Conversation

tombh
Copy link
Collaborator

@tombh tombh commented May 19, 2024

I manually added the new lines into this very PR template in this comment...

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Automated linters

You can run the lints that are run on CI locally with:

poetry install --all-extras --with dev
poetry run poe lint

@tombh tombh requested a review from alcarney May 19, 2024 23:39
@tombh tombh mentioned this pull request May 19, 2024
Merged
6 tasks
@tombh tombh merged commit f46a8b9 into main May 20, 2024
17 checks passed
@tombh tombh deleted the tombh/add-poetry-linter-to-pull-request-template branch May 20, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcarney alcarney alcarney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombh @alcarney