ci: don't let Pyodide test fail the whole build #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcarney
previously approved these changes
Nov 29, 2023
tombh
force-pushed
the
tombh/disable-pyodide-tests
branch
from
2c1b0cc to
e5513b3
Compare
tombh
force-pushed
the
tombh/disable-pyodide-tests
branch
from
e5513b3 to
78b84a7
Compare
|
It doesn't seem to. It still considers the whole build to have failed putting that red cross icon next to the commit message. So I've just added Also, there's another cheeky commit that just prevents both on-push and on-pull_request CI runs running at once. |
Strange... as the summary header in the Actions tab considered it a success 🤷♂️
Seems fine to me |
alcarney
approved these changes
Nov 30, 2023
|
Yeah, I saw that too. Seems odd that they wouldn't then reflect that status in icons next to the commit messages. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.