Remove dependency on typeguard
#411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks. Just request a review from me or Alex when this is ready. |
|
@tombh I don't have permissions to add reviewers. This is ready now for review. |
tombh
approved these changes
Nov 10, 2023
|
Oh, sorry, I didn't realise. It looks good, I've approved it. I'll just wait a bit in case Alex gets a chance to look too. |
alcarney
approved these changes
Nov 10, 2023
|
Would you like a Pygls release? Or wait a bit for some bleeding edge testers? |
|
I will do more tests with a few servers and let you know. |
6 tasks
|
I tested this on a few different servers. It seems to be working as expected. This can be published. |
tombh
added a commit
that referenced
this pull request
Nov 16, 2023
* Remove dependency on `typeguard` by @karthiknadig in #411 * Simplify vscode-playground setup and fix Python discovery by @alcarney in #374
Merged
tombh
added a commit
that referenced
this pull request
Nov 16, 2023
* Remove dependency on `typeguard` by @karthiknadig in #411 * Simplify vscode-playground setup and fix Python discovery by @alcarney in #374
|
Great, thank you. Here's the PR for the release #412 |
tombh
added a commit
that referenced
this pull request
Nov 18, 2023
* Remove dependency on `typeguard` by @karthiknadig in #411 * Simplify vscode-playground setup and fix Python discovery by @alcarney in #374
tombh
added a commit
that referenced
this pull request
Nov 18, 2023
* Remove dependency on `typeguard` by @karthiknadig in #411 * Simplify vscode-playground setup and fix Python discovery by @alcarney in #374
tombh
added a commit
that referenced
this pull request
Nov 18, 2023
* Remove dependency on `typeguard` by @karthiknadig in #411 * Simplify vscode-playground setup and fix Python discovery by @alcarney in #374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
Remove dependency on
typeguard.fixes #409
Code review checklist (for code reviewer to complete)