Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: split protocol.py into own folder/files #398

Merged
merged 1 commit into from
Oct 7, 2023
Merged

chore: split protocol.py into own folder/files #398

merged 1 commit into from
Oct 7, 2023

Conversation

tombh
Copy link
Collaborator

@tombh tombh commented Oct 7, 2023

No other changes apart from just moving code around.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

@tombh tombh requested a review from alcarney October 7, 2023 13:03
@tombh tombh merged commit ca23f34 into main Oct 7, 2023
34 checks passed
@tombh tombh deleted the tombh/file-splitting branch October 7, 2023 19:40
@tombh tombh mentioned this pull request Oct 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcarney alcarney alcarney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombh @alcarney