-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more capability unit tests and enable coverage reporting #380
Conversation
(I don't care either way about the import changes: except that that putting such things into the same commit as the actual substantial change that you are making is unhelpful for reviewers!) I'd suggest that the default value for |
8f202a3
to
3ab7990
Compare
Apologies! I probably should've marked this as draft before, as I wasn't necessarily expecting a review 😅 |
I approved the PR, but @dimbleby, please chime in as well if anything stands out. Coverage is a nice touch! Thoughts for another time: |
3ab7990
to
159b6e7
Compare
Up to you. Another option is to copy the attrs project and have the report show up in the workflow summary. It looks like it would be fairly easy to setup |
This makes the `default` argument to the `_provider_options` argument mandatory so that each usage is explicit about the type of `value` the following code is expecting to handle.
This should make it easier to fix errors all in one go
159b6e7
to
d11bb9a
Compare
Yeah having the summary in the workflow like that is nice. I'll see if I can add that soon. |
Description (e.g. "Related to ...", etc.)
This PR attempts to address issues around computing server capabilities raised in #377
_provider_options
method is now annotated, allowing mypy to check it's usage.default
argument to_provide_options
has been made mandatory.Also
poe
will now always run all lints, even when some of them fail so that it's possible to see all failures at once.Code review checklist (for code reviewer to complete)