fix: only show code action when there's no sum #379
Conversation
|
It looks like the regex now captures newline character at the end of the line which ending up in the code action title and failing the test. If you stripped the matched text that should fix it. action = CodeAction(
- title=f"Evaluate '{match.group(0)}'",
+ title=f"Evaluate '{match.group(0).strip()}'",
kind=CodeActionKind.QuickFix,
edit=WorkspaceEdit(changes={document_uri: [text_edit]}),
)Thanks again for opening this :) |
|
Thanks for all your help getting started with pygls :) I see what you mean about the newline character. Suspect the |
|
I've pushed a commit that changes the If you prefer the version that uses |
Tighten the ADDITION regex so that the 'Evaluate' code action only appears if there's no sum. Previously, after using the action, the lightbulb remained visible in VSCode and would keep appending the sum to the line, resulting in things like `1 + 1 = 2! 2! 2!`
The previous regex included trailing whitespace, including newline character, in the match. This meant the code action title (shown to users to trigger the action) had that trailing whitespace and newline. This version of the regex uses a lookahead to check the `=` is followed by the end of the string or by whitespace and then the end of the string. (I.e. that the addition doesn't already have a sum.) The values in the lookahead aren't included in the match groups. The trigger is only shown when users hover
No need! It was just the first solution that came to mind - I’d argue that yours is much more elegant anyway! |
Description
In examples/code_actions, tighten the ADDITION regex so that the 'Evaluate' code action only appears if there's no sum. Previously, after using the action, the lightbulb remained visible in VSCode and would keep appending the sum to the line, resulting in things like
1 + 1 = 2! 2! 2!Code review checklist (for code reviewer to complete)