Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspace symbol resolve #362

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

karthiknadig
Copy link
Contributor

@karthiknadig karthiknadig commented Aug 31, 2023

Description (e.g. "Related to ...", etc.)

Add support for workspace symbol resolve request.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

@karthiknadig
Copy link
Contributor Author

@alcarney @tombh I did not see a test for workspace symbol, this change updates existing support for workspace symbol to enable resolve if "workspaceSymbol/resolve" is implemented.

@tombh
Copy link
Collaborator

tombh commented Sep 1, 2023

Great, thank you. It looks like a pretty straightforward change. Just needs a rebase of main and we can get this merged?

@karthiknadig
Copy link
Contributor Author

@tombh re-based to main.

@karthiknadig karthiknadig marked this pull request as ready for review September 1, 2023 18:42
@tombh
Copy link
Collaborator

tombh commented Sep 1, 2023

Damn, needs rebasing again! Busy day for that pygls/capabilities.py file, which is great 💪

Also, does this contribute to the LSP 3.17 support as well? Outlined in #346

@karthiknadig
Copy link
Contributor Author

karthiknadig commented Sep 1, 2023

@tombh Yes this covers the symbol resolve.

@tombh tombh self-requested a review September 1, 2023 21:16
@tombh tombh merged commit f95f693 into openlawlibrary:main Sep 1, 2023
@tombh
Copy link
Collaborator

tombh commented Sep 1, 2023

Great 🎉 Thank you.

@karthiknadig karthiknadig deleted the feature1 branch September 1, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants