Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: retry Pyodide tests #355

Merged
merged 1 commit into from
Jul 30, 2023
Merged

ci: retry Pyodide tests #355

merged 1 commit into from
Jul 30, 2023

Conversation

tombh
Copy link
Collaborator

@tombh tombh commented Jul 29, 2023

This is to get around a curious issue that isn't resolved by dependency locking. The flakey error is:

ImportError: cannot import name 'Any' from 'typing_extensions'

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

This is to get around a curious issue that isn't resolved by dependency
locking. The flakey error is:

`ImportError: cannot import name 'Any' from 'typing_extensions'`
@tombh tombh force-pushed the tombh/retry-pyodide-tests branch from d758f0b to 3f51a57 Compare July 29, 2023 22:28
@tombh tombh requested a review from alcarney July 29, 2023 22:34
@alcarney
Copy link
Collaborator

Sorry, I keep meaning to look into this.

Looking at things more closely, I think the pip install step based on a locked set of dependencies that was added in 476eaf1 should probably be moved to here

Aside from the selenium stuff, run.py only needs to package pygls plus it’s test suite into a wheel so that it can be pushed inside the pyodide runtime where the tests are actually run. It’s this "hidden" pip install step inside the runtime itself that is causing the issue and needs some help picking the right version of everything.

Copy link
Collaborator

@alcarney alcarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great workaround for the meantime though 😄

@tombh
Copy link
Collaborator Author

tombh commented Jul 30, 2023

Ahh, yes that makes sense, it's the Pyodide runtime that needs the pinned deps. So there's still a chance 😀

But no rush, this PR should get us by.

@tombh tombh merged commit 7fe0f7c into main Jul 30, 2023
@tombh tombh deleted the tombh/retry-pyodide-tests branch July 30, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants