-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inlay hint support #342
Conversation
Amazing to see these tests doing their magic, hats off. So just waiting on that Pyodide test and the |
It's that flaky one we saw before... so it looks like I'll have to revisit the pyodide test runner before long |
Ohh yes, right I see. Ok, what are you thinking then? Some pinning? |
At least a lower version bound on lsprotocol |
Sure ✨
Greta, and I think I can just close fix: Pin lsprotocol depdency #345 because I'd have to update it to the later version that you need here. A git blame and these comments and issue references are good enough papertrail I think. Awesome work again Alex 🤓 |
Oh, BTW, I guess you don't need a Pygls release? But might as well do one anyway? My only hesitancy is the lsprotocol pin, I'll mention it in #345. |
A new release would be nice... though do we want to push and get support for all of v3.17 in first? It would also give a bit of time for the new release of |
I must admit I didn't even think Pygls even supported all of 3.16. I guess we get a lot for free now by depending on
What are the main things you think would be good to get in Pygls? |
Well... I'm assuming we do! 😅 It would be interesting to know if we have any gaps.
We do get a lot for free now, I think somewhere between 1/2 - 2/3 of that list is just new fields on types coming from Work for us to do is the new methods
And these
I would imagine we can do nearly all of that apart from |
It was just an assumption. I've come across gaps over the months, and perhaps I mistakenly assumed they were for older versions, whereas in fact they're legitimate gaps in the recent 3.17 spec.
😏 Great, so I've made a dedicated issue for the remaining 3.17 features #346
I actually am in a good position do that one because of all the detailed work on #304 |
Description (e.g. "Related to ...", etc.)
textDocument/inlayHint
andinlayHint/resolve
requests from v3.17 of the spec.Note: This requires a fix to
lsprotocol
in order work correctly (microsoft/lsprotocol#219)Code review checklist (for code reviewer to complete)