Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link and outdated comment #337

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

seeM
Copy link
Contributor

@seeM seeM commented May 24, 2023

Description (e.g. "Related to ...", etc.)

Fixes a broken link to lsprotocol in the docs, as well as an outdated comment (I think) pointing to pygls.lsp.methods which should point to lsprotocol too. Also a typo.

It's such a small change that I don't think contributors or changelog need to be updated.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@tombh tombh merged commit b0d81e5 into openlawlibrary:master May 24, 2023
@tombh
Copy link
Collaborator

tombh commented May 24, 2023

This is great! Thank you ♥️

@seeM
Copy link
Contributor Author

seeM commented May 25, 2023

My pleasure! And thank you for your work on pygls! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants