Improve the logic of grace period #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furykerry
reviewed
Aug 7, 2024
myname4423
force-pushed
the
improve
branch
3 times, most recently
from
19c1336 to
1308b4d
Compare
furykerry
reviewed
Aug 13, 2024
pkg/util/grace/grace_expectations.go
Outdated
| } | ||
|
|
||
| func (r *realGraceExpectations) SatisfiedExpectations(controllerKey string, action Action, graceSeconds int32) (bool, time.Duration) { | ||
| r.Lock() |
| klog.Infof("%s start finalising traffic routing", c.Key) | ||
| // remove stable service the pod revision selector, so stable service will be selector all version pods. | ||
| verify, err := m.restoreStableService(c) | ||
| if err != nil || !verify { | ||
| if retry, err := m.RestoreStableService(c); err != nil || retry { |
There was a problem hiding this comment.
plz add log before each steps in this func
| // returning (false, nil) means the update has been submitted, and no error occurred | ||
| // but we need to wait graceful time before returning true | ||
| func (m *Manager) PatchStableService(c *TrafficRoutingContext) (bool, error) { | ||
| func (m *Manager) RemoveCanaryService(c *TrafficRoutingContext) (bool, error) { |
There was a problem hiding this comment.
plz comment the return variable
Signed-off-by: yunbo <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
use a map to store key(resource and action) and value (last modified time), if an operation require a grace period after update, we record the time of update, so that next time we can check if the grace period expires before executing this operation again.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews