webhook validate v1beta1 rollout #188
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
- Coverage 43.40% 43.36% -0.05%
==========================================
Files 52 52
Lines 5667 5659 -8
==========================================
- Hits 2460 2454 -6
+ Misses 2783 2782 -1
+ Partials 424 423 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zmberg
force-pushed
the
fix-v1beta1-webhook
branch
2 times, most recently
from
9cd94f3 to
cd65e92
Compare
api/v1alpha1/conversion.go
Outdated
| @@ -74,7 +74,8 @@ func (src *Rollout) ConvertTo(dst conversion.Hub) error { | |||
| obj.Spec.Strategy.Canary.PatchPodTemplateMetadata.Labels[k] = v | |||
| } | |||
| } | |||
| if src.Annotations[RolloutStyleAnnotation] != string(PartitionRollingStyle) { | |||
| if src.Annotations[RolloutStyleAnnotation] != string(PartitionRollingStyle) && | |||
| srcSpec.ObjectRef.WorkloadRef.Kind == "Deployment" { | |||
There was a problem hiding this comment.
we should also convert traffic annotation to TrafficRoutingRef
zmberg
force-pushed
the
fix-v1beta1-webhook
branch
2 times, most recently
from
eab3a1f to
52ec5d2
Compare
zmberg
force-pushed
the
fix-v1beta1-webhook
branch
from
52ec5d2 to
52b0574
Compare
zmberg
force-pushed
the
fix-v1beta1-webhook
branch
from
52b0574 to
1b71bae
Compare
zmberg
force-pushed
the
fix-v1beta1-webhook
branch
3 times, most recently
from
338a862 to
d3b723a
Compare
Signed-off-by: liheng.zms <[email protected]>
zmberg
force-pushed
the
fix-v1beta1-webhook
branch
from
d3b723a to
3475d30
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews