Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support rolling publishing in AI scenarios #187

Closed
wants to merge 7 commits into from

Conversation

crain-cn
Copy link

Ⅰ. Describe what this PR does

Support rolling publishing in AI scenarios.

Ⅱ. Does this pull request fix one issue?

  1. Fix webhook ValidatingWebhookConfiguration support for apiVersion v1beta1.
  2. Support Istio getaway to filter VirtualService retries fields.

Ⅲ. Special notes for reviews

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @crain-cn! It looks like this is your first PR to openkruise/rollouts 🎉

@crain-cn crain-cn force-pushed the feature/knative-serving branch 2 times, most recently from d2d2068 to 7cac136 Compare December 11, 2023 12:20
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9dcf365) 43.40% compared to head (6e1e064) 43.36%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   43.40%   43.36%   -0.05%     
==========================================
  Files          52       52              
  Lines        5667     5659       -8     
==========================================
- Hits         2460     2454       -6     
+ Misses       2783     2782       -1     
+ Partials      424      423       -1     
Flag Coverage Δ
unittests 43.36% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crain-cn crain-cn force-pushed the feature/knative-serving branch from 7cac136 to 72ba828 Compare December 12, 2023 02:11
@kruise-bot kruise-bot added size/M and removed size/S labels Dec 12, 2023
@kruise-bot kruise-bot added size/S and removed size/M labels Dec 12, 2023
@crain-cn crain-cn force-pushed the feature/knative-serving branch from 67c129b to d5ef739 Compare December 12, 2023 07:05
@kruise-bot kruise-bot added size/M and removed size/S labels Dec 15, 2023
@crain-cn crain-cn closed this Jan 3, 2024
@crain-cn crain-cn deleted the feature/knative-serving branch January 3, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants