Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait grace period seconds after pod creation/upgrade when traffic rolling #185

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

veophi
Copy link
Member

@veophi veophi commented Nov 21, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and zmberg November 21, 2023 10:07
@veophi veophi force-pushed the wait_seconds branch 2 times, most recently from fef89e5 to 1b761dd Compare November 23, 2023 11:59
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (07b7f20) 43.56% compared to head (5bb8ee0) 43.59%.

Files Patch % Lines
pkg/trafficrouting/manager.go 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   43.56%   43.59%   +0.03%     
==========================================
  Files          52       52              
  Lines        5672     5677       +5     
==========================================
+ Hits         2471     2475       +4     
- Misses       2778     2779       +1     
  Partials      423      423              
Flag Coverage Δ
unittests 43.59% <87.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg
Copy link
Member

zmberg commented Dec 19, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Dec 19, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit e19a89c into openkruise:master Dec 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants