Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gateway print log panic #167

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Aug 9, 2023

Ⅰ. Describe what this PR does

@kruise-bot kruise-bot requested review from FillZpp and furykerry August 9, 2023 06:59
@sonatype-lift
Copy link

sonatype-lift bot commented Aug 9, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@codecov-commenter
Copy link

Codecov Report

Merging #167 (dfbfa1f) into master (2986258) will not change coverage.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   43.34%   43.34%           
=======================================
  Files          50       50           
  Lines        5373     5373           
=======================================
  Hits         2329     2329           
  Misses       2647     2647           
  Partials      397      397           
Flag Coverage Δ
unittests 43.34% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/trafficrouting/network/gateway/gateway.go 54.26% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@veophi
Copy link
Member

veophi commented Dec 19, 2023

/lgtm

@veophi
Copy link
Member

veophi commented Dec 19, 2023

/approve

1 similar comment
@zmberg
Copy link
Member Author

zmberg commented Dec 19, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: veophi, zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit bc580a3 into openkruise:master Dec 19, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants