fix lua script and test case

Signed-off-by: Megrez Lu <[email protected]>
openkruise · Jun 27, 2024 · 1d2ac3c · 1d2ac3c
1 parent 894a142
commit 1d2ac3c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/pkg/trafficrouting/network/customNetworkProvider/custom_network_provider_test.go b/pkg/trafficrouting/network/customNetworkProvider/custom_network_provider_test.go
@@ -472,7 +472,7 @@ func TestEnsureRoutes(t *testing.T) {
 					"virtual":              "test",
 				}
 				u.SetAnnotations(annotations)
-				specStr := `{"hosts":["echoserver.example.com"],"http":[{"match":[{"headers":{"user_id":{"exact":"123456"}}}],"route":[{"destination":{"host":"echoserver-canary"}}]},{"route":[{"destination":{"host":"echoserver"}}]}]}`
+				specStr := `{"hosts":["echoserver.example.com"],"http":[{"headers":{"request":{"set":{"x-env-flag":"canary"}}},"match":[{"headers":{"user_id":{"exact":"123456"}}}],"route":[{"destination":{"host":"echoserver-canary"}}]},{"route":[{"destination":{"host":"echoserver"}}]}]}`
 				var spec interface{}
 				_ = json.Unmarshal([]byte(specStr), &spec)
 				u.Object["spec"] = spec

diff --git a/...omNetworkProvider/lua_configuration/networking.istio.io/VirtualService/trafficRouting.lua b/...omNetworkProvider/lua_configuration/networking.istio.io/VirtualService/trafficRouting.lua
@@ -143,9 +143,7 @@ function GenerateMatchedRoutes(spec, matches, stableService, canaryService, stab
                 if action == "set" or action == "add" then
                     route["headers"]["request"][action] = {}
                     for _, header in ipairs(headers) do
-                        local h = {}
-                        h[header["name"]] = header["value"]
-                        table.insert(route["headers"]["request"][action], h)
+                        route["headers"]["request"][action][header["name"]] = header["value"]
                     end
                 elseif action == "remove" then
                     route["headers"]["request"]["remove"] = {}