Add composite provider to support multiple network providers #1132
lujiajing1126ci.yaml
on: pull_request
golangci-lint
1m 28s
unit-tests
1m 32s
Annotations
6 errors and 4 warnings
|
golangci-lint:
pkg/trafficrouting/network/composite.go#L28
cannot use (CompositeController)(nil) (value of type CompositeController) as type NetworkProvider in variable declaration:
|
|
golangci-lint:
pkg/trafficrouting/network/composite.go#L58
multiple-value provider.Finalise(ctx) (value of type (bool, error)) in single-value context (typecheck)
|
|
golangci-lint
issues found
|
|
unit-tests:
pkg/trafficrouting/network/composite.go#L28
cannot use (CompositeController)(nil) (value of type CompositeController) as type NetworkProvider in variable declaration:
|
|
unit-tests:
pkg/trafficrouting/network/composite.go#L58
multiple-value provider.Finalise(ctx) (value of type (bool, error)) in single-value context
|
|
unit-tests
Process completed with exit code 2.
|
|
golangci-lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-go@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
golangci-lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-go@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
unit-tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-go@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
unit-tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-go@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|