Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kruise E2E image registry and fix image pulling #894

Merged

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Jan 18, 2022

Signed-off-by: FillZpp [email protected]

Ⅰ. Describe what this PR does

  1. Improve Kruise E2E cases
  2. Make E2E image registry to be configurable
  3. Fix image pulling for specific images like docker.io/library/nginx:1.14-alpine

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #894 (7241418) into master (007ef53) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   47.84%   47.89%   +0.05%     
==========================================
  Files         119      119              
  Lines       11239    11239              
==========================================
+ Hits         5377     5383       +6     
+ Misses       5044     5039       -5     
+ Partials      818      817       -1     
Flag Coverage Δ
unittests 47.89% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/cloneset_controller.go 52.96% <0.00%> (+2.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007ef53...7241418. Read the comment docs.

@FillZpp FillZpp force-pushed the e2e-image-prefix-registry-configuration branch from adc4bc0 to c50bd82 Compare January 18, 2022 13:55
@FillZpp FillZpp force-pushed the e2e-image-prefix-registry-configuration branch from c50bd82 to 7241418 Compare January 19, 2022 02:34
@@ -82,7 +82,7 @@ var _ = SIGDescribe("BroadcastJob", func() {

framework.KruiseDescribe("BroadcastJob dispatching", func() {

ginkgo.It("succeeds for parallelism < number of node", func() {
framework.ConformanceIt("succeeds for parallelism < number of node", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change the test to conformance test ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the e2e framework is based on k8s e2e framework. But we should not use ConformanceIt here.Need fix it

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member Author

FillZpp commented Jan 19, 2022

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FillZpp FillZpp merged commit af3e254 into openkruise:master Jan 19, 2022
FillZpp added a commit that referenced this pull request Jan 21, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants