-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Kruise E2E image registry and fix image pulling #894
Improve Kruise E2E image registry and fix image pulling #894
Conversation
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
+ Coverage 47.84% 47.89% +0.05%
==========================================
Files 119 119
Lines 11239 11239
==========================================
+ Hits 5377 5383 +6
+ Misses 5044 5039 -5
+ Partials 818 817 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
adc4bc0
to
c50bd82
Compare
Signed-off-by: FillZpp <[email protected]>
c50bd82
to
7241418
Compare
@@ -82,7 +82,7 @@ var _ = SIGDescribe("BroadcastJob", func() { | |||
|
|||
framework.KruiseDescribe("BroadcastJob dispatching", func() { | |||
|
|||
ginkgo.It("succeeds for parallelism < number of node", func() { | |||
framework.ConformanceIt("succeeds for parallelism < number of node", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change the test to conformance test ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the e2e framework is based on k8s e2e framework. But we should not use ConformanceIt here.Need fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: FillZpp <[email protected]>
Signed-off-by: FillZpp [email protected]
Ⅰ. Describe what this PR does
docker.io/library/nginx:1.14-alpine