Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal for PreNormalHook #1111

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

veophi
Copy link
Member

@veophi veophi commented Oct 26, 2022

Signed-off-by: mingzhou.swx [email protected]

Ⅰ. Describe what this PR does

Add proposal for PreNormalHook

Ⅱ. Does this pull request fix one issue?

#1071

@kruise-bot kruise-bot requested review from Fei-Guo and FillZpp October 26, 2022 07:00
@kruise-bot kruise-bot added the size/M size/M: 30-99 label Oct 26, 2022
@veophi veophi force-pushed the post-create-hook-proposal branch from 8274288 to ffb4eb8 Compare October 26, 2022 07:05
@veophi veophi changed the title Add proposal for PostCreateHook Add proposal for PreNormalHook Oct 26, 2022
@veophi veophi force-pushed the post-create-hook-proposal branch from ffb4eb8 to 4abeeb7 Compare October 26, 2022 13:01
@veophi veophi requested review from furykerry and zmberg and removed request for FillZpp and Fei-Guo November 7, 2022 12:22
Signed-off-by: mingzhou.swx <[email protected]>
@veophi veophi force-pushed the post-create-hook-proposal branch from 4abeeb7 to 120bfdb Compare November 7, 2022 12:35
@zmberg
Copy link
Member

zmberg commented Jan 5, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Jan 5, 2023

/approve

@zmberg
Copy link
Member

zmberg commented Jan 5, 2023

/assign @furykerry

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry, zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit bab1a31 into openkruise:master Jan 5, 2023
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants