pod probe marker webhook #1078

zmberg · 2022-09-16T05:56:26Z

Signed-off-by: liheng.zms [email protected]

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

codecov-commenter · 2022-09-16T06:07:25Z

Codecov Report

Merging #1078 (110dbcb) into master (16277db) will increase coverage by 0.00%.
The diff coverage is 56.83%.

@@           Coverage Diff            @@
##           master    #1078    +/-   ##
========================================
  Coverage   50.29%   50.30%            
========================================
  Files         126      127     +1     
  Lines       17855    17994   +139     
========================================
+ Hits         8980     9051    +71     
- Misses       7886     7943    +57     
- Partials      989     1000    +11

Flag	Coverage Δ
unittests	`50.30% <56.83%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...bemarker/validating/probe_create_update_handler.go	`56.83% <56.83%> (ø)`
pkg/controller/cloneset/cloneset_controller.go	`52.94% <0.00%> (-2.25%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pkg/webhook/podprobemarker/validating/probe_create_update_handler.go

furykerry

/lgtm

FillZpp · 2022-09-16T07:30:49Z

pkg/webhook/add_podprobemarker.go

@@ -0,0 +1,25 @@
+/*
+Copyright 2021.


FillZpp · 2022-09-20T09:36:05Z

pkg/webhook/add_podprobemarker.go

@@ -0,0 +1,25 @@
+/*
+Copyright 2021.


FillZpp · 2022-09-20T09:41:37Z

pkg/webhook/podprobemarker/validating/probe_create_update_handler.go

+		numHandlers++
+		allErrors = append(allErrors, field.Forbidden(fldPath.Child("probe"), "current only support exec probe"))
+	}
+	if numHandlers == 0 {


validate numHandlers should not > 1

FillZpp · 2022-09-20T09:42:36Z

pkg/webhook/podprobemarker/validating/probe_create_update_handler.go

+		numHandlers++
+		allErrors = append(allErrors, validateExecAction(handler.Exec, fldPath.Child("exec"))...)
+	}
+	if handler.HTTPGet != nil || handler.TCPSocket != nil {


Should not check handler.HTTPGet != nil || handler.TCPSocket != nil, so that if there are both HTTPGet and TCPSocket, numHandlers will only be 1

furykerry · 2022-09-21T12:29:23Z

pkg/webhook/podprobemarker/validating/probe_create_update_handler.go

+		uniqueProbe.Insert(probe.Name)
+		allErrs = append(allErrs, validateProbe(&probe.Probe, fldPath.Child("probe"))...)
+		if probe.PodConditionType == "" && len(probe.MarkerPolicy) == 0 {
+			allErrs = append(allErrs, field.Invalid(fldPath.Child("probes"), spec.Selector, "podConditionPostfix and markerPolicy cannot be empty at the same time"))


podConditionPostfix -> podConditionType

FillZpp · 2022-09-22T06:21:16Z

/lgtm

Signed-off-by: liheng.zms <[email protected]>

FillZpp · 2022-09-23T02:36:26Z

/lgtm

furykerry

/lgtm

furykerry · 2022-09-23T02:49:06Z

/approve

kruise-bot · 2022-09-23T02:49:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [furykerry]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: peng.xin <[email protected]> optimize workloadspread when suitable subset maxReplicas is niil (openkruise#1066) Signed-off-by: mingzhou.swx <[email protected]> Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> Optimize performance of LabelSelector conversion (openkruise#1068) Signed-off-by: FillZpp <[email protected]> Signed-off-by: FillZpp <[email protected]> Support timezone for AdvancedCronJob (openkruise#1070) Signed-off-by: FillZpp <[email protected]> Signed-off-by: FillZpp <[email protected]> ignore if pod condition has been updated (openkruise#1074) Signed-off-by: mingzhou.swx <[email protected]> Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> pod probe marker apis (openkruise#1073) * pod probe marker apis Signed-off-by: liheng.zms <[email protected]> * fix statefulset truncateHistory panic Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> pod probe marker controller (openkruise#1075) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> consider whether patch field is matched when assign existing pods to subset (openkruise#1083) Signed-off-by: mingzhou.swx <[email protected]> Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> pod probe marker webhook (openkruise#1078) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> sidecarset support pods ns(kube-system, kube-public) (openkruise#1084) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> pod probe marker proposal (openkruise#1053) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> node pod probe daemon (openkruise#1077) Signed-off-by: liheng.zms <[email protected]> sidecarset support patch pod metadata proposal (openkruise#993) Signed-off-by: liheng.zms <[email protected]> Support predownload image in ads (openkruise#1057) Signed-off-by: Abner <[email protected]> * support predownload image for ads Add PreDownloadImageForDaemonSetUpdate featureGate (openkruise#1093) Signed-off-by: FillZpp <[email protected]> Signed-off-by: FillZpp <[email protected]> Add changelog for v1.3.0 (openkruise#1092) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> fix sidecarset inject annotations abnormal (openkruise#1101) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> fix InPlaceUpdateEnvFromMetadata bug (openkruise#1108) Co-authored-by: 郭已钦 <[email protected]> support uniteddeployment persistentVolumeClaimRetentionPolicy inherit from advancestatefulset template (openkruise#1110) Signed-off-by: cheyuexian <[email protected]> Signed-off-by: cheyuexian <[email protected]> Co-authored-by: cheyuexian <[email protected]> Add PreNormal Lifecycle Hook for CloneSet (openkruise#1071) * add pre-normal(pre-available) hook Signed-off-by: mingzhou.swx <[email protected]> * add pre-normal(pre-available) hook Signed-off-by: mingzhou.swx <[email protected]> Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> partition support float percent (openkruise#1124) Signed-off-by: shiyan2016 <[email protected]> Signed-off-by: shiyan2016 <[email protected]> improve error hanlding of inplace update env from metadata (openkruise#1125) Signed-off-by: mingzhou.swx <[email protected]> Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> pub support to configure Evict,Delete,Update Operation (openkruise#1126) Signed-off-by: liheng.zms <[email protected]> Signed-off-by: liheng.zms <[email protected]> feat: add watch whitelist feat: add watch whitelist add watch whitelist check add dynamic watch option feat: add persistent annotations format feat: add pps support custom workload Signed-off-by: peng.xin <[email protected]> fix: nodeSelector and nodeAffinity have not been modified Signed-off-by: peng.xin <[email protected]> fix: error string Signed-off-by: peng.xin <[email protected]> fix: error string Signed-off-by: peng.xin <[email protected]> fix: goimports Signed-off-by: peng.xin <[email protected]> refactor: refactoring ersistentPodAnnotations type Signed-off-by: peng.xin <[email protected]> - add statefulet group check - modify the pod create processing logic Signed-off-by: peng.xin <[email protected]> refactor: pps watch of whitelist workload Signed-off-by: peng.xin <[email protected]> fix: add statefulsetlike's pod controller Signed-off-by: peng.xin <[email protected]>

kruise-bot requested review from FillZpp and furykerry September 16, 2022 05:56

kruise-bot added the size/XL size/XL: 500-999 label Sep 16, 2022

furykerry reviewed Sep 20, 2022

View reviewed changes

pkg/webhook/podprobemarker/validating/probe_create_update_handler.go Show resolved Hide resolved

furykerry reviewed Sep 20, 2022

View reviewed changes

kruise-bot assigned furykerry Sep 20, 2022

kruise-bot added the lgtm label Sep 20, 2022

FillZpp reviewed Sep 20, 2022

View reviewed changes

zmberg force-pushed the pod-probe-marker-webhook branch from 110dbcb to 619450a Compare September 21, 2022 12:18

kruise-bot removed the lgtm label Sep 21, 2022

furykerry reviewed Sep 21, 2022

View reviewed changes

zmberg force-pushed the pod-probe-marker-webhook branch 3 times, most recently from 8695d4e to d0dc034 Compare September 22, 2022 02:47

kruise-bot assigned FillZpp Sep 22, 2022

kruise-bot added the lgtm label Sep 22, 2022

zmberg force-pushed the pod-probe-marker-webhook branch from d0dc034 to 67b8e77 Compare September 22, 2022 08:43

kruise-bot removed the lgtm label Sep 22, 2022

pod probe marker webhook

a41afb9

Signed-off-by: liheng.zms <[email protected]>

zmberg force-pushed the pod-probe-marker-webhook branch from 67b8e77 to a41afb9 Compare September 22, 2022 12:00

kruise-bot added the lgtm label Sep 23, 2022

furykerry reviewed Sep 23, 2022

View reviewed changes

kruise-bot added the approved label Sep 23, 2022

kruise-bot merged commit 7314c73 into openkruise:master Sep 23, 2022

zmberg deleted the pod-probe-marker-webhook branch September 26, 2022 10:03

ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024

pod probe marker webhook (openkruise#1078)

968c875

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pod probe marker webhook #1078

pod probe marker webhook #1078

zmberg commented Sep 16, 2022

codecov-commenter commented Sep 16, 2022

furykerry left a comment

FillZpp Sep 16, 2022

FillZpp Sep 20, 2022

FillZpp Sep 20, 2022

FillZpp Sep 20, 2022

furykerry Sep 21, 2022

FillZpp commented Sep 22, 2022

FillZpp commented Sep 23, 2022

furykerry left a comment

furykerry commented Sep 23, 2022

kruise-bot commented Sep 23, 2022

pod probe marker webhook #1078

pod probe marker webhook #1078

Conversation

zmberg commented Sep 16, 2022

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

codecov-commenter commented Sep 16, 2022

Codecov Report

furykerry left a comment

Choose a reason for hiding this comment

FillZpp Sep 16, 2022

Choose a reason for hiding this comment

FillZpp Sep 20, 2022

Choose a reason for hiding this comment

FillZpp Sep 20, 2022

Choose a reason for hiding this comment

FillZpp Sep 20, 2022

Choose a reason for hiding this comment

furykerry Sep 21, 2022

Choose a reason for hiding this comment

FillZpp commented Sep 22, 2022

FillZpp commented Sep 23, 2022

furykerry left a comment

Choose a reason for hiding this comment

furykerry commented Sep 23, 2022

kruise-bot commented Sep 23, 2022