Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/svc name #92

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Feat/svc name #92

merged 2 commits into from
Aug 9, 2023

Conversation

chrisliu1995
Copy link
Member

No description provided.

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 8, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@kruise-bot kruise-bot requested review from FillZpp and zmberg August 8, 2023 13:22
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #92 (02b9a94) into master (3f5a1ea) will decrease coverage by 0.05%.
The diff coverage is 14.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   29.77%   29.73%   -0.05%     
==========================================
  Files          19       19              
  Lines        2495     2499       +4     
==========================================
  Hits          743      743              
- Misses       1707     1711       +4     
  Partials       45       45              
Flag Coverage Δ
unittests 29.73% <14.28%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...trollers/gameserverset/gameserverset_controller.go 0.00% <0.00%> (ø)
pkg/util/gameserver.go 38.02% <ø> (+0.52%) ⬆️
...controllers/gameserverset/gameserverset_manager.go 47.20% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ringtail
Copy link
Member

ringtail commented Aug 9, 2023

/LGTM

@kruise-bot kruise-bot added the lgtm label Aug 9, 2023
@ringtail ringtail merged commit 649ab11 into openkruise:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants