Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to sync gs metadata from from gsTemplate #85

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

chrisliu1995
Copy link
Member

#83

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 13, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@kruise-bot kruise-bot requested review from FillZpp and zmberg July 13, 2023 08:36
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furykerry for approval by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #85 (997790f) into master (c4e4197) will decrease coverage by 0.25%.
The diff coverage is 12.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   30.06%   29.82%   -0.25%     
==========================================
  Files          18       18              
  Lines        2365     2401      +36     
==========================================
+ Hits          711      716       +5     
- Misses       1609     1640      +31     
  Partials       45       45              
Flag Coverage Δ
unittests 29.82% <12.82%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/controllers/gameserver/gameserver_controller.go 0.00% <0.00%> (ø)
pkg/controllers/gameserver/gameserver_manager.go 36.17% <0.00%> (-3.37%) ⬇️
pkg/util/gameserver.go 34.28% <100.00%> (+2.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisliu1995 chrisliu1995 force-pushed the enhance/gs_metadata branch from 997790f to d9d3454 Compare July 13, 2023 08:42
@ringtail
Copy link
Member

/LGTM

@ringtail ringtail merged commit dcc3d82 into openkruise:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants