feat: add ReserveIds ScaleDownStrategyType #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrisLiu <[email protected]>
|
Please add doc to introduce the scenario and CRD field. |
Signed-off-by: ChrisLiu <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ringtail The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackGround
Sometimes, we need to scale down the game servers and no longer create those automatically until those game servers are manually specified to be recreated.
Solution
The ScaleDownStrategyType field is added to the scale strategy. When the ScaleDownStrategyType is ReserveIds, the ID of the scaled down game server will be backfilled in the reserveGameServerIds field. When the user wants to recreate it, remove the ID from the reserveGameServerIds field and increase the replicas, which can meet the above requirements.