Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid gs status sync delay when network failure #45

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

chrisliu1995
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #45 (ed716b5) into master (b1f3d94) will decrease coverage by 0.05%.
The diff coverage is 42.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   26.01%   25.96%   -0.05%     
==========================================
  Files          15       15              
  Lines        1968     1964       -4     
==========================================
- Hits          512      510       -2     
+ Misses       1417     1414       -3     
- Partials       39       40       +1     
Flag Coverage Δ
unittests 25.96% <42.85%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/controllers/gameserver/gameserver_controller.go 0.00% <0.00%> (ø)
pkg/controllers/gameserver/gameserver_manager.go 39.90% <50.00%> (-0.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ringtail ringtail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ringtail
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ringtail ringtail merged commit af327dc into openkruise:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants