Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Unit Tests for controllers #44

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

chrisliu1995
Copy link
Member

No description provided.

@kruise-bot kruise-bot requested review from furykerry and zmberg March 21, 2023 04:01
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furykerry for approval by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #44 (7603347) into master (f585041) will increase coverage by 3.51%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   22.50%   26.01%   +3.51%     
==========================================
  Files          13       15       +2     
  Lines        1502     1968     +466     
==========================================
+ Hits          338      512     +174     
- Misses       1144     1417     +273     
- Partials       20       39      +19     
Flag Coverage Δ
unittests 26.01% <ø> (+3.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ringtail
Copy link
Member

/LGTM

@ringtail ringtail merged commit b1f3d94 into openkruise:master Mar 23, 2023
@chrisliu1995 chrisliu1995 deleted the Add_UT branch April 27, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants