feat: export prometheus metrics #40
Conversation
chrisliu1995
force-pushed
the
feat/export_metrics
branch
from
12a4395 to
6deda64
Compare
|
Add some docs and Grafana dashboard json |
chrisliu1995
force-pushed
the
feat/export_metrics
branch
from
6deda64 to
3c9182a
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -97,7 +100,8 @@ func main() { | |||
| } | |||
| } | |||
|
|
|||
| mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{ | |||
| restConfig := ctrl.GetConfigOrDie() | |||
There was a problem hiding this comment.
GO-2023-1568: A path traversal vulnerability exists in filepath.Clean on Windows.
On Windows, the filepath.Clean function could transform an invalid path such as "a/../c:/b" into the valid path "c:\b". This transformation of a relative (if invalid) path into an absolute path could enable a directory traversal attack.
After fix, the filepath.Clean function transforms this path into the relative (but still invalid) path ".\c:\b".
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
There was a problem hiding this comment.
@sonatype-lift ignore
There was a problem hiding this comment.
I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 22.50% 26.22% +3.71%
==========================================
Files 13 16 +3
Lines 1502 1987 +485
==========================================
+ Hits 338 521 +183
- Misses 1144 1426 +282
- Partials 20 40 +20
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: ChrisLiu <[email protected]>
chrisliu1995
force-pushed
the
feat/export_metrics
branch
from
3c9182a to
f4d056c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ringtail The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: ChrisLiu <[email protected]>
Signed-off-by: ChrisLiu [email protected]