alibabacloud slb support map same TCP and UDP port , eg 8000/TCPUDP #197
Conversation
| @@ -144,8 +144,11 @@ func initLbCache(svcList []corev1.Service, minPort, maxPort int32, blockPorts [] | |||
| var ports []int32 | |||
| for _, port := range getPorts(svc.Spec.Ports) { | |||
| if port <= maxPort && port >= minPort { | |||
| newCache[lbId][port] = true | |||
| ports = append(ports, port) | |||
| value, ok := newCache[lbId][port] | |||
There was a problem hiding this comment.
you cannot redeploy the service that not controlled by kruise-game but use same port.
There was a problem hiding this comment.
cache just save lbId + port when design, it has no Protocol Attribute；
when use 8000/TCPUDP, cache just lbid:8000 and map to tcp:8000 udp:8000 two svc items;
when reinit cache , list tcp:8000 and udp:8000 should repeat to lbid:8000
else when 8000/TCPUDP, 9000/TCP will map error ....
There was a problem hiding this comment.
here svc all filter by SlbIdLabelKey , all controlled by kruise-game ?
There was a problem hiding this comment.
I don't think there is a problem to set map true for two times. And the svc using SlbIdLabelKey may be deployed by user self, not all controlled by kruise-game.
There was a problem hiding this comment.
-
set cache map true two times has no problem , but append
podAllocatetwo times maybe problem; eg: when config 8000/TCPUDP,9000/TCP , first createpodAllocateis lb:8000,9000 , when reinitpodAllocatewith append two times, result is lb:8000,8000,9000, it will be error when resync svc; -
filter all svc by SlbIdLabelKey manager by kruise-game or not, record lb port to cache avoid allocated; I think is right ,
podAllocatesvc item not control by kruise-game never used ...
|
Are you already in our dingtalk community group(44862615)? @gaopeiliang |
I will Join .... |
cloudprovider/alibabacloud/slb.go
Outdated
| } | ||
| } | ||
| if len(ports) != 0 { | ||
| newPodAllocate[svc.GetNamespace()+"/"+svc.GetName()] = lbId + ":" + util.Int32SliceToString(ports, ",") | ||
| log.Infof("svc %s/%s allocate slb %s ports %v", svc.Namespace, svc.Name, lbId, ports) |
There was a problem hiding this comment.
The log is unnecessary, cause podAllocate will be printed when finished the initialization.
I had add your dingtalk account, you can check that. |
Sometime we want map slb UDP and TCP same port to Container .. More like a "Host"