Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FailurePolicy of PodMutatingWebhook turn to Fail #129

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

chrisliu1995
Copy link
Member

@chrisliu1995 chrisliu1995 commented Feb 2, 2024

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9c203d0) 39.96% compared to head (b1dfd54) 40.30%.

Files Patch % Lines
cloudprovider/kubernetes/hostPort.go 0.00% 5 Missing ⚠️
cloudprovider/alibabacloud/slb.go 0.00% 1 Missing ⚠️
cloudprovider/volcengine/clb.go 0.00% 1 Missing ⚠️
pkg/webhook/mutating_pod.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   39.96%   40.30%   +0.33%     
==========================================
  Files          28       28              
  Lines        3923     3913      -10     
==========================================
+ Hits         1568     1577       +9     
+ Misses       2267     2248      -19     
  Partials       88       88              
Flag Coverage Δ
unittests 40.30% <57.89%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhipeng629
Copy link
Contributor

/LGTM

@kruise-bot
Copy link

@lizhipeng629: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ringtail
Copy link
Member

/LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants