Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature: Service Quality #11

Merged
merged 16 commits into from
Nov 1, 2022
Merged

Add feature: Service Quality #11

merged 16 commits into from
Nov 1, 2022

Conversation

chrisliu1995
Copy link
Member

@chrisliu1995 chrisliu1995 commented Oct 17, 2022 •
edited
Loading

Service Quality: Probe GameServers' status, and mark the results automatically

@chrisliu1995
Copy link
Member Author

/assign @ringtail

@zmberg zmberg requested review from zmberg, FillZpp and ringtail October 18, 2022 02:40
@chrisliu1995 chrisliu1995 reopened this Oct 18, 2022
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrisliu1995
update gencerts.sh
4ff82af 
Signed-off-by: ChrisLiu <[email protected]>
(cherry picked from commit a18f9be)
@chrisliu1995
remove markdown checker
5e72c1a 
Signed-off-by: ChrisLiu <[email protected]>
(cherry picked from commit 937f453)
@chrisliu1995
update UT checker
d1b828b 
Signed-off-by: ChrisLiu <[email protected]>
(cherry picked from commit ba2f55d)
@chrisliu1995
add golangci-lint timeout arg
19d1156 
Signed-off-by: ChrisLiu <[email protected]>
(cherry picked from commit 1ef8b25)
@chrisliu1995
add doc of architecture
a471b09 
Signed-off-by: ChrisLiu <[email protected]>
(cherry picked from commit 5014c70)
@chrisliu1995
add e2e test checker
161d831 
Signed-off-by: ChrisLiu <[email protected]>
(cherry picked from commit 97fbed9)
@chrisliu1995
update test case to adapt to different registries
3a76213 
Signed-off-by: ChrisLiu <[email protected]>
(cherry picked from commit 68b368b)
@chrisliu1995
update e2e cluster kruise version to 1.3.0
f8fe6b4 
Signed-off-by: ChrisLiu <[email protected]>
zmberg
zmberg reviewed Oct 18, 2022
View reviewed changes
apis/v1alpha1/gameserver_types.go Show resolved Hide resolved
pkg/controllers/gameserver/gameserver_manager.go Outdated Show resolved Hide resolved
pkg/controllers/gameserver/gameserver_manager.go Outdated Show resolved Hide resolved
pkg/controllers/gameserver/gameserver_manager.go Show resolved Hide resolved
pkg/controllers/gameserver/gameserver_controller.go Outdated Show resolved Hide resolved
pkg/controllers/gameserver/gameserver_manager.go Show resolved Hide resolved
pkg/controllers/gameserverset/gameserverset_manager.go Show resolved Hide resolved
apis/v1alpha1/gameserverset_types.go Outdated Show resolved Hide resolved
pkg/util/gameserver.go Show resolved Hide resolved
pkg/controllers/gameserverset/gameserverset_manager.go Outdated Show resolved Hide resolved
@ringtail
Copy link
Member

ringtail commented Nov 1, 2022

/LGTM

@kruise-bot kruise-bot added the lgtm label Nov 1, 2022
@ringtail ringtail merged commit f563275 into openkruise:master Nov 1, 2022
@chrisliu1995 chrisliu1995 mentioned this pull request Nov 24, 2022
Closed
6 tasks
@chrisliu1995 chrisliu1995 deleted the service_quality branch April 27, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmberg zmberg zmberg left review comments

@FillZpp FillZpp Awaiting requested review from FillZpp

@ringtail ringtail Awaiting requested review from ringtail

Assignees

@ringtail ringtail

Labels
lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisliu1995 @kruise-bot @ringtail @zmberg