fix: fix navigation failed of anchor element. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssgcg1213
reviewed
Mar 23, 2021
yuanyan
reviewed
Mar 23, 2021
answershuto
reviewed
Mar 23, 2021
| @@ -25,7 +25,7 @@ mixin EventHandlerMixin on Node { | |||
| renderBoxModel.onPointerMove = handlePointMove; | |||
| renderBoxModel.onPointerUp = handlePointUp; | |||
| renderBoxModel.onPointerCancel = handlePointCancel; | |||
| renderBoxModel.onClick = dispatchEvent; | |||
| renderBoxModel.onClick = handleClick; | |||
There was a problem hiding this comment.
handleClick 的实现也就是 Event 参数的透传，没必要封装一层 handleClick 吧。
wssgcg1213
reviewed
Mar 23, 2021
| @@ -365,6 +365,8 @@ class KrakenViewController { | |||
| } catch (e, stack) { | |||
| if (navigationDelegate.errorHandler != null) { | |||
| navigationDelegate.errorHandler(e, stack); | |||
| } else { | |||
| print('Kraken navigation failed: $e\n$stack'); | |||
There was a problem hiding this comment.
参考 Chrome 的用语习惯 (我们在 Bridge 里有使用类似的).
Kraken: Failed to navigate to "$sourceUrl". 会更合适一些.
Kraken navigation failed 直译是中文语法习惯.
There was a problem hiding this comment.
|
需补充用例 |
现在还测不了 |
yuanyan
approved these changes
Mar 24, 2021
|
Can't approve, cc @temper357 @answershuto to review. |
answershuto
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72