-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: DiffOpt: Parallel optimization of Jax models #7522
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Dear Reviewers @landreman and @ewu63 You can start by creating your task lists. Each list will contain several tasks. As you complete each task, you can check off the corresponding checkbox. Since the review process for JOSS is interactive, you are encouraged to engage with the author, other reviewers, and the editor throughout. You can open issues and submit pull requests in the target repository. Please include the URL of this page in those interactions, so we can keep track of activities outside of the platform. To generate your task list, simply type:
Thank you in advance. |
Review checklist for @landremanConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @ewu63Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
All the items in the checklist are complete so I approve the paper for publication. Is there anything more I need to do to sign off? |
@landreman - Thank you for your review. By now, nothing to do in your side. Whenever we get the final action from the other reviewer, I'll start my editorial stuff. |
I am also finished with the review and checked all items off. |
@ewu63 - Don't you have any additional suggestions/corrections or something else? Could you provide me a brief reviewer report with 3-4 sentences? I am writing this post because it seems you haven't presented any counter ideas and suggestions and it looks like your decision is to accept as is, right? |
@jbytecode the only comment I had was here regarding references. The main module of the library, |
@ewu63 - Thank you for the clarification. |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
Done. Here is the requested info:
|
@AlanPearl - The metadata of manuscript should match those in the Zenodo archive, please add contributors to the authors list with the proper information including their DOIs. Thank you in advance. |
@editorialbot set v1.1.1 as version |
@AlanPearl - The manuscript looks almost perfect. I've just sent a pull request that includes minor fixes in both the manuscript and the bibliography (AlanPearl/diffopt#7). Please review the PR, if you're okay with them, please merge. |
@editorialbot check references |
|
@editorialbot generate pdf |
@AlanPearl - The manuscript looks good to me. Please perform a full read of the paper and fix any thing if you think it's wrong. Please tell me when you've done with them. Thank you in advance. |
@jbytecode Okay I have finished my final reading, and it looks good to me. |
@editorialbot check references |
|
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6261, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot generate pdf 🔍 checking out the following:
|
@editorialbot accept Very clean paper. Thank you! |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🥳 Congratulations on your new publication @AlanPearl ! Many thanks to @jbytecode for editing and @landreman and @ewu63 for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @AlanPearl (Alan Pearl)
Repository: https://github.com/AlanPearl/diffopt
Branch with paper.md (empty if default branch): paper
Version: v1.1.1
Editor: @jbytecode
Reviewers: @landreman, @ewu63
Archive: 10.5281/zenodo.14291795
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@landreman & @ewu63, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @landreman
📝 Checklist for @ewu63
The text was updated successfully, but these errors were encountered: