-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: DelaunayTriangulation.jl: A Julia package for Delaunay triangulations and Voronoi tessellations in the plane #7174
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
|
Review checklist for @PieterjanRobbeConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @mtschConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
I've made some changes in response to @PieterjanRobbe's comments over at JuliaGeometry/DelaunayTriangulation.jl#181, and made some other minor changes. The pdf has been regenerated, see above. To summarise:
Thanks again to @PieterjanRobbe for the comments, I appreciate it. |
@editorialbot generate pdf |
I've made some changes in response to @mtsch's comments over at JuliaGeometry/DelaunayTriangulation.jl#189. The pdf has been regenerated, see above. To summarise:
Thanks again @mtsch, I appreciate your feedback. |
@editorialbot generate pdf |
(Just fixed a minor reference issue) |
@editorialbot generate pdf |
@mtsch, @PieterjanRobbe thanks a lot for your efforts! It seems that your checklists are completed. Are your finished with your reviews and recommend acceptance? |
@DanielVandH I opened an issue in the repository with some editing suggestions. |
Looks good to me! |
To address @vissarion's comments at JuliaGeometry/DelaunayTriangulation.jl#190, I've:
to give more detail. This isn't in the paper itself due to space reasons, but I do refer back to it.
Thanks again for the feedback. |
@vissarion I'm finished with my review and I think this paper will make a great addition to JOSS! The package, its documentation, and paper are all top notch in my opinion. |
@DanielVandH thanks for addressing my comments. In particular, the table of related software and the comparisons looks great! However I think it would be good to double-check the table data once more especially the licenses part (e.g. I think that CGAL has multiple open source licenses for several parts and the option for commercial, but in your case only the triangulations package should be considered). Although, I am not an expert in licensing so this is just an advice and can be done independently from the submission. |
Continuing on the review part when a submission is ready to be accepted, we ask that the authors issue a new tagged release of the software (if changed), and archive it (see this guide). Please do this and post the version number and archive DOI here. |
Thanks for pointing out that issue with CGAL's licenses. Indeed there is also a triangulation package there with a GNU GPL license. I mention now that it has GPL/GNU GPL/Commerical licenses. I've tagged a new version (v1.4.2) of the package. I already had a Zenodo setup at https://zenodo.org/records/13847646 which has been updated accordingly; the DOI is https://doi.org/10.5281/zenodo.13847646. Is that all correct? |
@editorialbot set 10.5281/zenodo.13847646 as archive |
Done! archive is now 10.5281/zenodo.13847646 |
@editorialbot set v1.4.2 as version |
Done! version is now v1.4.2 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5925, then you can now move forward with accepting the submission by compiling again with the command |
👋 @DanielVandH - As the track editor, I'm now reviewing this for final publication. It looks very good, though I have one question. There's no acknowledgment section, so I want to check to make sure this is intentional and that you don't want to mention any funding or other acknowledgements. Is this correct? |
That's correct |
@editorialbot accept |
|
I'll check on this, and close it if it's done, in about 30 minutes... |
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @DanielVandH (Daniel VandenHeuvel) on your publication!! And thanks to @PieterjanRobbe and @mtsch for reviewing, and to @vissarion for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Congratulations! |
Thanks all! |
Submitting author: @DanielVandH (Daniel VandenHeuvel)
Repository: https://github.com/JuliaGeometry/DelaunayTriangulation.jl
Branch with paper.md (empty if default branch): paper
Version: v1.4.2
Editor: @vissarion
Reviewers: @PieterjanRobbe, @mtsch
Archive: 10.5281/zenodo.13847646
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@PieterjanRobbe & @mtsch, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @vissarion know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @PieterjanRobbe
📝 Checklist for @mtsch
The text was updated successfully, but these errors were encountered: