Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ASTE: An artificial solver testing environment for partitioned coupling with preCICE #7064

Closed
editorialbot opened this issue Aug 1, 2024 · 40 comments
Assignees
Labels
C++ CMake pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 1, 2024

Submitting author: @davidscn (David Schneider)
Repository: https://github.com/precice/aste
Branch with paper.md (empty if default branch): paper
Version: v3.2.0
Editor: @diehlpk
Reviewers: @asalmgren, @hverhelst
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/461395f81bcedd77828c4b44f53b7179"><img src="https://joss.theoj.org/papers/461395f81bcedd77828c4b44f53b7179/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/461395f81bcedd77828c4b44f53b7179/status.svg)](https://joss.theoj.org/papers/461395f81bcedd77828c4b44f53b7179)

Author instructions

Thanks for submitting your paper to JOSS @davidscn. Currently, there isn't a JOSS editor assigned to your paper.

@davidscn if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Aug 1, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.11 s (933.2 files/s, 325065.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                     8           3248           4216          17733
Python                          14            421            163           2512
JSON                             8              1              0           2086
C++                             15            266            109           1608
XML                             28            157             36           1583
Markdown                         4            122              0            359
YAML                             8              6             13            324
CMake                            2             40             64            150
TeX                              1             12              0            121
Bourne Shell                    13             41             30            100
make                             1              3              0              6
-------------------------------------------------------------------------------
SUM:                           102           4317           4631          26582
-------------------------------------------------------------------------------

Commit count by author:

   125	David Schneider
   117	Frédéric Simonis
   109	Florian Lindner
    67	Kursat Yurt
    56	Kürşat Yurt
    18	--global
    18	Frederic Simonis
     8	David Sommer
     7	Gerasimos Chourdakis
     6	Kursat_Yurt
     6	S0mmerD
     5	Kyle Davis
     4	Benjamin Uekermann
     4	Kursat
     4	dependabot[bot]
     3	Boris Martin
     1	Guillaume De Nayer
     1	Klaudius Scheufele
     1	timo-schrader
     1	uekerman

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.12688/openreseurope.14445.2 is OK
- 10.3390/a14060166 is OK
- 10.18419/darus-4167 is OK
- 10.18419/opus-10581 is OK
- 10.1002/nme.2579 is OK

MISSING DOIs

- 10.23967/c.coupled.2023.016 may be a valid DOI for title: Data-parallel radial-basis-function interpolation ...
- No DOI given, and none found for title: Robust and Efficient Barycentric Cell-Interpolatio...
- No DOI given, and none found for title: Second-order projection-based mapping methods for ...
- No DOI given, and none found for title: The Visualization Toolkit (4th ed.)
- 10.1007/978-3-030-47956-5_10 may be a valid DOI for title: ExaFSA: Parallel Fluid-Structure-Acoustic Simulati...
- No DOI given, and none found for title: MeTis: Unstructured Graph Partitioning and Sparse ...
- No DOI given, and none found for title: JSON for Modern C++

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1133

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Micro Manager: a Python package for adaptive and flexible two-scale coupling
Submitting author: @IshaanDesai
Handling editor: @philipcardiff (Active)
Reviewers: @mayrmt, @mrogowski, @mbkumar
Similarity score: 0.7310

Akantu: an HPC finite-element library for contact and dynamic fracture simulations
Submitting author: @nrichart
Handling editor: @diehlpk (Active)
Reviewers: @vijaysm, @chennachaos
Similarity score: 0.7185

DMStag: Staggered, Structured Grids for PETSc
Submitting author: @psanan
Handling editor: @kyleniemeyer (Active)
Reviewers: @elauksap, @mbarzegary
Similarity score: 0.7119

ogs6py and VTUinterface: streamlining OpenGeoSys workflows in Python
Submitting author: @joergbuchwald
Handling editor: @leouieda (Retired)
Reviewers: @cpgr, @TobbeTripitaka, @akaszynski
Similarity score: 0.7108

AMReX: a framework for block-structured adaptive mesh refinement
Submitting author: @asalmgren
Handling editor: @kyleniemeyer (Active)
Reviewers: @MatthewTurk, @RemiLehe, @cmsquared
Similarity score: 0.7070

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

@davidscn - thanks for your submission. While I look for an editor, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@danielskatz
Copy link

👋 @diehlpk - would you be willing to edit this submission?

@danielskatz
Copy link

@editorialbot invite @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@diehlpk
Copy link
Member

diehlpk commented Aug 1, 2024

@danielskatz yes, I can do it but only can start in the second week of August.

@diehlpk
Copy link
Member

diehlpk commented Aug 1, 2024

@editorialbot add @diehlpk as reviewer

@editorialbot
Copy link
Collaborator Author

Can't add reviewers: There is no editor assigned yet

@danielskatz
Copy link

@editorialbot add @diehlpk as editor

Thanks!

@editorialbot
Copy link
Collaborator Author

Assigned! @diehlpk is now the editor

@davidscn
Copy link

davidscn commented Aug 7, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.12688/openreseurope.14445.2 is OK
- 10.3390/a14060166 is OK
- 10.18419/darus-4167 is OK
- 10.23967/c.coupled.2023.016 is OK
- 10.18419/opus-12128 is OK
- 10.18419/opus-10581 is OK
- 10.1007/978-3-030-47956-5_10 is OK
- 10.1002/nme.2579 is OK

MISSING DOIs

- No DOI given, and none found for title: Robust and Efficient Barycentric Cell-Interpolatio...
- No DOI given, and none found for title: The Visualization Toolkit (4th ed.)
- No DOI given, and none found for title: MeTis: Unstructured Graph Partitioning and Sparse ...
- No DOI given, and none found for title: JSON for Modern C++

INVALID DOIs

- None

@davidscn
Copy link

davidscn commented Aug 7, 2024

@editorialbot generate pdf

I added now missing DOIs where possible. For the remaining entries, there are at most URLs given and no DOIs available. If that's a problem, I would consider to embed the mentioned URL into the plain text rather than making it a full citation.

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@diehlpk
Copy link
Member

diehlpk commented Aug 9, 2024

@IshaanDesai do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Aug 9, 2024

Hi @psanan do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Aug 9, 2024

Hi @asalmgren do you have time to review this paper?

@IshaanDesai
Copy link

@diehlpk I work in the same research group as the authors of this paper. If this is a conflict of interest, then I am not a good fit here. If this is not an issue, I am happy to be a reviewer.

@diehlpk
Copy link
Member

diehlpk commented Aug 14, 2024

@IshaanDesai that would be COI. Would you mind suggestion other reviewers?

@diehlpk
Copy link
Member

diehlpk commented Aug 14, 2024

@davidscn could you please recommend some potential reviewers?

@asalmgren
Copy link

asalmgren commented Aug 14, 2024 via email

@diehlpk
Copy link
Member

diehlpk commented Aug 15, 2024

@asalmgren That would not be any problem.

@diehlpk
Copy link
Member

diehlpk commented Aug 15, 2024

@editorialbot add @asalmgren as reviewer

@editorialbot
Copy link
Collaborator Author

@asalmgren added to the reviewers list!

@davidscn
Copy link

@davidscn could you please recommend some potential reviewers?

Not entirely sure about the prerequisites to be a reviewer. Of course, we could suggest again the reviewers from #5842, as they are somewhat familiar with the preCICE-verse and JOSS. Other than that I could maybe suggest @hverhelst or @antRthorn. Would that comply with the JOSS formalities?

@diehlpk
Copy link
Member

diehlpk commented Aug 20, 2024

HI @hverhelst do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Aug 20, 2024

Hi @antRthorn do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Aug 20, 2024

Hi @IshaanDesai do you have time to review this paper?

@hverhelst
Copy link

Hi @diehlpk, thanks for the invite! I have time from the first week of September onwards, is that OK?

@IshaanDesai
Copy link

Hi @IshaanDesai do you have time to review this paper?

Due to the clear conflict of interest that we previously discussed, I have to decline here.

@diehlpk
Copy link
Member

diehlpk commented Aug 22, 2024

@editorialbot add @hverhelst as reviewer

@editorialbot
Copy link
Collaborator Author

@hverhelst added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Aug 22, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7127.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ CMake pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

7 participants