-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: seesus: a social, environmental, and economic sustainability classifier for Python #6244
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@editorialbot add @luyuhao0326 to reviewers |
@luyuhao0326 added to the reviewers list! |
👋 Hi @varsha2509, @luyuhao0326, thank you so much for helping out at JOSS. If you need any pointers, please feel free to look at previous reviews (which can be found by looking at published papers) and the documentation. If you need to comment on the code itself, opening an issue at the repo and then linking to it from here (to help me/others keep track) is the way to go. For comments on the paper, you can also open issues or PRs (say for typos), but those can be directly posted as replies in this issue. Thanks, and feel free to reach out if you need me. |
Review checklist for @luyuhao0326Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Thanks for the invitation and below are my reviews on installation, and software paper (most of my comments will be related to the paper since I am not a proficient Python user). Installation
Software paper
|
Hi @luyuhao0326, Thank you very much for taking the time to review Installation
Thank you for your suggestion.
I am more than happy to help. Do you already have Python, pip, and Jupyter (for running the Software paper
Glad to hear that you find our package novel and potentially useful in many domains. To achieve the best results, we recommend splitting a paragraph or a whole document into individual sentences (i.e., using individual sentences as the basic unit for
Thank you for your suggestion. We have incorporated additional context of text mining on SDGs in our paper as suggested (c8162fe). Given that JOSS requires papers to be between 250-1000 words (source), we hope the edits are sufficient to provide the necessary improvement to our statement of need.
This is a great idea. We’ve added a statement on maintenance in Thanks again for your time and suggestions! |
@editorialbot generate pdf |
@caimeng2 Thanks for your response. I will get back to you within a week or so. I will also try to install the package and give feedback if there is any. Yuhao |
Hello, I managed to install the package and while testing one of the provided examples, I encountered a LookupError. Please see the code here. |
Hi @luyuhao0326, I'm so glad that you got the installation working 🎉 The link to the LookupError is pointing to your localhost so I can't see the traceback. But I suspect it's a bug with from seesus import SeeSus
import re
text2 = "By working with communities in the floodplain and facilitating flood-resistant building design, DCP is reducing the city’s risks to sea level rise and coastal flooding. Hurricane Sandy was a stark reminder of these risks. The City, led by the Mayor’s Office of Recovery and Resiliency (ORR), has developed a multifaceted plan for recovering from Sandy and improving the city’s resiliency–the ability of its neighborhoods, buildings and infrastructure to withstand and recover quickly from flooding and climate events. As part of this effort, DCP has initiated a series of projects to identify and implement land use and zoning changes as well as other actions needed to support the short-term recovery and long-term vitality of communities affected by Hurricane Sandy and other areas at risk of coastal flooding."
for sent in re.split(r'(?<!\w\.\w.)(?<![A-Z][a-z]\.)(?<=\.|\?)\s', text2):
result = SeeSus(sent)
print('"', sent, '"', sep = "")
print("Is the sentence related to achieving sustainability?", result.sus)
print("Which SDGs?", result.sdg)
print("Which SDG targets specifically?", result.target)
print("which dimensions of sustainability?", result.see)
print("----------------") Thank you for letting me know about this issue. I'll update the examples. |
Indeed this is the bug. It is now working with |
The authors have addressed all my comments and made appropriate revisions. I recommend this submission to be accepted by JOSS. |
Thanks again for your suggestions, which helped to make our paper and software better! |
@varsha2509 is everything going OK with your review? 😊 |
Review checklist for @varsha2509Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hello. Thank you for giving me the opportunity to review this work. This authors have done a great job documenting the software, installation instructions and the functionality. Below are my comments based on the review checklist as well as a additional notes to help improve readability and adoption of this work:
Other notes:
|
Hi @varsha2509, Thank you for taking the time to review our software and for your valuable feedback. Please find our point-by-point responses below.
Yes, we can confirm that all targets are included in the keywords. We created the search keys at the levels of both the 17 SDGs and the 169 SDG targets. The indirect keys were first based on Thesaurus, and we (four researchers specialized in SDGs) manually assessed and improved the accuracy of the matching syntax by using thousands of randomly-selected statements from corporate reports. We conducted three rounds of fine-tuning and finalized these keys.
Thank you for pointing this out. Indeed, matching with negative connotation is
The biggest benefit of
What we meant was
Thank you for this reference. We have added it to the existing classifiers. We tested
Thank you for your suggestion. This is a very good point. Compared to language models, regex lacks the ability to understand the semantic meaning or context of text, as it operates based on character patterns. As suggested, we have added a paragraph at the end of the paper to make the limitation of
Yes, we have included it in the revision of the paper. We devoted hundreds of hours to fine-tune the matching syntax. 75.5% seems low but it is quite reasonable for traditional qualitative analysis. The human intercoder agreement on the same text was only at 83%. Thanks again for all your comments and suggestions! We feel that our paper is much clearer and stronger than the previous version. Thank you!!! Please let us know if there's anything else. |
@caimeng2 why is it |
@caimeng2 see: caimeng2/seesus#3 |
Ah my bad. That was the version number for PyPI, which I totally forgot. Should have made them consistent |
Hi @oliviaguest, I made a new release and redid the tasks above. Sorry about the inconvenience.
Checked
Checked
Checked |
@caimeng2 thank you! |
@editorialbot generate pdf |
@editorialbot set v1.2.1 as version |
Done! version is now v1.2.1 |
@caimeng2 is that the right version? |
Yes! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5224, then you can now move forward with accepting the submission by compiling again with the command |
@caimeng2 can you check the final draft please before it's accepted? 🥳 |
We did, and everything looks good. Thank you for the smooth review process. I enjoyed it. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Huge thanks to @varsha2509, @luyuhao0326! ✨ JOSS appreciates your work and effort. ✨ Also, big congratulations to the author: @caimeng2! 🥳 🍾 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @caimeng2 (Meng Cai)
Repository: https://github.com/caimeng2/seesus
Branch with paper.md (empty if default branch):
Version: v1.2.1
Editor: @oliviaguest
Reviewers: @varsha2509, @luyuhao0326
Archive: 10.5281/zenodo.10854083
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@varsha2509, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @oliviaguest know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @luyuhao0326
📝 Checklist for @varsha2509
The text was updated successfully, but these errors were encountered: