Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: OGSUQ.jl: a Julia library implementing an uncertainty quantification toolbox for OpenGeoSys #5981

Closed
editorialbot opened this issue Oct 24, 2023 · 17 comments
Labels
Julia pre-review query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 6 (ESE) Earth Sciences and Ecology

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @baxmittens (maximilian bittens)
Repository: https://github.com/baxmittens/OGSUQ.jl
Branch with paper.md (empty if default branch):
Version: 0.1.0
Editor: Pending
Reviewers: Pending
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f5aae0a9f09a691a7eb8142de1169e3d"><img src="https://joss.theoj.org/papers/f5aae0a9f09a691a7eb8142de1169e3d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f5aae0a9f09a691a7eb8142de1169e3d/status.svg)](https://joss.theoj.org/papers/f5aae0a9f09a691a7eb8142de1169e3d)

Author instructions

Thanks for submitting your paper to JOSS @baxmittens. Currently, there isn't a JOSS editor assigned to your paper.

@baxmittens if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Oct 24, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (558.3 files/s, 37062.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                             14              0              7            690
Julia                            7             72             30            524
Markdown                         4            126              0            385
YAML                             4              3              4             95
TeX                              1              9              0             90
TOML                             1              2              0             21
-------------------------------------------------------------------------------
SUM:                            31            212             41           1805
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 633

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/100786356 is OK
- 10.1137/060663660 is OK
- 10.1016/j.jcp.2009.01.006 is OK
- 10.48550/arXiv.1509.01462 is OK
- 10.21105/joss.04300 is OK
- 10.1109/38.865875 is OK
- 10.21105/joss.05003 is OK

MISSING DOIs

- 10.1007/s12665-012-1546-x may be a valid DOI for title: OpenGeoSys: an open-source initiative for numerical simulation of thermo-hydro-mechanical/chemical (THM/C) processes in porous media

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

GlobalSensitivity.jl: Performant and Parallel Global Sensitivity Analysis with Julia
Submitting author: @Vaibhavdixit02
Handling editor: @jbytecode (Active)
Reviewers: @zhenwu0728, @storyetfall
Similarity score: 0.8372

MUQ: The MIT Uncertainty Quantification Library
Submitting author: @mparno
Handling editor: @pdebuyl (Active)
Reviewers: @martinmodrak, @georgiastuart
Similarity score: 0.8282

QXTools: A Julia framework for distributed quantum circuit simulation
Submitting author: @nmoran
Handling editor: @jarvist (Active)
Reviewers: @goerz, @obliviateandsurrender
Similarity score: 0.8265

ogs6py and VTUinterface: streamlining OpenGeoSys workflows in Python
Submitting author: @joergbuchwald
Handling editor: @leouieda (Retired)
Reviewers: @cpgr, @TobbeTripitaka, @akaszynski
Similarity score: 0.8264

UQit: A Python package for uncertainty quantification (UQ) in computational fluid dynamics (CFD)
Submitting author: @salrm8
Handling editor: @drvinceknight (Active)
Reviewers: @jayten, @ctdegroot
Similarity score: 0.8199

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@kthyng
Copy link

kthyng commented Oct 24, 2023

Hi @baxmittens and thanks for your submission. I am going to ping the editorial board to take a look due to its relatively small size. This process will take 1-2 weeks, thanks.

@kthyng
Copy link

kthyng commented Oct 24, 2023

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Oct 24, 2023
@baxmittens
Copy link

baxmittens commented Oct 25, 2023

Hi @kthyng
thank you for your efforts.
Please note that I subdivided this project into several github projects for better reusability

The underlying packages are

https://github.com/baxmittens/DistributedSparseGrids.jl

https://github.com/baxmittens/VTUFileHandler.jl

https://github.com/baxmittens/DistributedMonteCarlo.jl

https://github.com/baxmittens/Ogs6InputFileHandler.jl

https://github.com/baxmittens/XDMFFileHandler.jl

the first two have their own joss papers.

This is the third, and last, Joss paper for this project.

@danielskatz
Copy link

@baxmittens - Can you be explicit about which software you consider part of this submission?

@baxmittens
Copy link

@danielskatz

I don't really know how to answer this.

Hi @baxmittens and thanks for your submission. I am going to ping the editorial board to take a look due to its relatively small size. This process will take 1-2 weeks, thanks.

This answer really confuses me. Why should it be a bad thing that my software is of small size?
I outsourced each functionality which can be used in a broader range of applications in its own package. As I think it should be done.

OGSUQ.jl is an umbrella project for all the others.

But I think in the end OGSUQ.jl is a toolbox for wrapping a stochastic model around a deterministic OpenGeoSys model and the consequent integration over the defined stochastic state space.

That should be sufficient for an JOSS Paper right?

@danielskatz
Copy link

@baxmittens - I think you are mixing up two things here. @kthyng wrote the message you've quoted above, not me. But based on that and your response in #5981 (comment), I asked a clarifying question, about what software is associated with this submission.

The reason for this is that much like the fact that the same work shouldn't be published in multiple scientific papers, the same software shouldn't be published in multiple JOSS papers. So my question was which software is associated with this JOSS paper, as opposed to the software associated with the already published JOSS papers.

Additionally, this information is needed for the reviewers to know which software to review, if this submission goes to review.

Your answer doesn't really answer my question - it seems aimed at @kthyng's statement instead.

So I'll ask again, which software is associated with this paper?

@baxmittens
Copy link

Sorry, I misunderstood then.

Surely, it is about
https://github.com/baxmittens/OGSUQ.jl

The rest is just an explanation for why there are not that many lines of code.

The software has the unique feature that it produces a stochastic postprocessing result of the same form as the deterministic result. For example a VTU File with the expected value or variance dissolved in time and space as defined in the determinstic project

@kthyng
Copy link

kthyng commented Nov 20, 2023

@baxmittens Sorry for the extended delay. The JOSS editorial board has voted this submission to be out of scope due to its small size using the number of lines of code as a proxy for substantial scholarly effort. This is not meant to be a judgement on the software quality or usefulness, but in following our journal guidelines. You might consider other routes for publication or if this package expands under future development, you may consider submitting it then (and link to this issue). Thank you.

@kthyng
Copy link

kthyng commented Nov 20, 2023

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Julia pre-review query-scope Submissions of uncertain scope for JOSS rejected TeX Track: 6 (ESE) Earth Sciences and Ecology
Projects
None yet
Development

No branches or pull requests

4 participants