-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Shiny tools for management rules: interactive applications that aid in conservation strategies for North Atlantic right whales #5436
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Hi all! Welcome to the review thread! 🎉 While our excellent reviewers gather their comments, could you please double-check the missing DOIs on the paper, @leahcrowe? Thanks! @TanyaS08 and @salix-d - thank you so much for accepting to be part of this discussion! As the bot has mentioned, you can learn more about the review process here. Do not hesitate to contact me if you need anything. [= |
Review checklist for @TanyaS08Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf DOIs updated! |
Review checklist for @salix-dConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi! I was trying to test the functionnality with the example_data/20210409. I checked 'local' and entered the path where I saved the files in that folder, entered '210409' as the 'Survey Date', but I couldn't find the 'Tail number'. I tried without and got the error:
Do you have the tail number somewhere in this repo? Another thing is that you need an 'Example usage'. I think you could easily add with the example data so people can get a feel of what can be done. Thanks! |
I'm going to attach/insert myself here as well since I had the same issue (I also added some dummy digits for a flight number - same message). I was wondering if it might also be an OS issue when setting the path? I'm running macOS for what it's worth... |
And I'm on windows. ( kinda nice we cover multiple OS to test :) ) |
Hi all, Thank you for agreeing to test this app. We are grateful for your involvement and review! You don't need to include a tail number to proceed, but I have updated the wiki page with an example tail number: https://github.com/NEFSC/READ-PSB-LWT-narwss_rwsas_apps/wiki/Aerial-Survey-Processing-App,-Aerial-Survey-Tab:-Part-1 The issue you all were running into was that I incorrectly named the folder containing the example data (was YYYYMMDD when it should have been YYMMDD). All good now, and I have updated the README file with how to run the example data (without needing to download anything to your machine). I'm aware that you all will not be able to test the trigger evaluation without access to our database server, so I am working on an example workaround. Hopefully at least the processing app goes a bit more smoothly for you -- sorry about that mix up! Leah |
The problem was that I thought the path to the files included the folder Perhaps " the pathway you enter should be the pathway where the edit files are stored." could be change to something like " the pathway you enter should be the pathway to the folder containing the edit files are stored. This file should also be labeled like [YYMMDD]." |
For the dependencies, I notice that if I don't load the libraries, they get loaded when doing Since the review check list mentionned that
I would suggest using |
I was able to download the report in html but not in pdf format. I had this error :
Here's the log file: Don't know if related, but the html file was named "09Apr2021_NOAA_NERW_Aerial_Report.html" and the pdf file "report.htm". |
This is an issue that occurs related to tinytex/your machine's LaTeX distribution. I offer up some tests/installation instructions in the "Additional installation" README section. I have been able to set this up on several different computers and our shiny server, but some computers have eluded me, which is why we have offered the html download option. The correct naming convention is added to the file when it works properly. |
Hi all, I've added in three more example days of data that offer different scenarios for the trigger analysis from the aerial survey data (see the README file for the update). For our functional operations, we have this app interacting on our internal server and database, so I can't offer up that actual experience, but I hope the examples I have provided demonstrate how this app is going through the decision making process for triggering protection zones, or not. Please let me know if there is anything further you would like to see to proceed. Leah |
I've also had an issue with creating the PDF (but everything else works! 😊). My error message looks a bit different though and says the following: which is then followed by: Warning: Error in : LaTeX failed to compile /var/folders/wf/wmp7x6xj7_zbx2bl9z5ysfwm0000gn/T//Rtmpuirwmm/file947ed0e2974.tex. See https://yihui.org/tinytex/r/#debugging for debugging tips. See file947ed0e2974.log for more info. It could be that I also have an underlying LATEX issue but I was wondering about the |
I am thinking this has to do with your LaTeX distribution and if it recognizes "\n" as a line break or if it is looking for a different command. Likely it doesn't like the single "" in how your machine is set up. Our team just compiled the attached report the other day, so we do have this up and running properly on our server, but it's also exactly why we also offer the html option! |
I'm wondering if there is a way to word this issue better in the README/wiki. I looked at it again and it is there but maybe in the README under the 'Additional installations' section it might be nice to have a sub-sub heading that is something along the lines of 'troubleshooting for PDF report generation'? And a phrase that echos what is in the README that PDF generation is hard but try these links for troubleshooting or generate the report as an .html and convert to PDF from there. Having just written that it might clog up the README so maybe even just a simple hyperlink linking to the wiki (https://github.com/NEFSC/READ-PSB-LWT-narwss_rwsas_apps/wiki/Aerial-Survey-Processing-App,-Aerial-Survey-Tab:-Part-3) to make the link more clear/make the user aware of this potential issue? |
Hopefully I've done this right - I've opened an issue regarding documentation here: |
|
Nice catch! I just pushed the edit! |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4409, then you can now move forward with accepting the submission by compiling again with the command |
Ok final checks:
|
@leahcrowe Please check the capitalization in your references. You can preserve capitalization by placing {} around characters/words in your .bib file. |
@kthyng Thanks for that catch! Should be good now! |
@kthyng is there anything more I should do after pushing that edit? Thanks for your help! |
@leahcrowe sorry I have been out of town since I wrote that. Catching up now. |
@editorialbot generate pdf |
Ok looks ready to go! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @leahcrowe! Many thanks to editor @graciellehigino and reviewers @TanyaS08 and @salix-d for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you to everyone! This was a great experience and we really appreciate the thoughtful reviews! |
Submitting author: @leahcrowe (Leah Crowe)
Repository: https://github.com/NEFSC/READ-PSB-LWT-narwss_rwsas_apps
Branch with paper.md (empty if default branch):
Version: v1.1.0
Editor: @graciellehigino
Reviewers: @TanyaS08, @salix-d
Archive: 10.5281/zenodo.8127594
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@TanyaS08 & @salix-d, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @graciellehigino know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @TanyaS08
📝 Checklist for @salix-d
The text was updated successfully, but these errors were encountered: