-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: FrESCO: Framework for Exploring Scalable Computational Oncology #5345
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
Howdy @gabeerion and @SimonBiggs! Thanks for agreeing to review this submission. The process for conducting a review is outlined above. Please run the command shown above to have @editorialbot generate your checklist, which will give a step-by-step process for conducting your review. Please check the boxes during your review to keep track, as well as make comments in this thread or open issues in the repository itself to point out issues you encounter. Keep in mind that our aim is to improve the submission to the point where it is of high enough quality to be accepted, rather than to provide a yes/no decision, and so having a conversation with the authors is encouraged rather than providing a single review post at the end of the process. Here are the review guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html Please let me know if you encounter any issues or need any help during the review process, and thanks for contributing your time to JOSS and the open source community! |
Review checklist for @SimonBiggsConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
|
Review checklist for @gabeerionConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @SimonBiggs @gabeerion, how are the reviews coming? |
Hi @jmschrei, Not yet begun. I'm hoping to be able to earmark some time next week. |
@jmschrei actively working on my review over last week and the coming one, thanks! |
Hi @aspannaus, I was hoping to be able to report an issue, however your issue list is locked down in such a way that I cannot create an account through the web interface. Would it be possible for you to make a fork of this repository on GitHub where I can access the code without needing an ornl.gov account? |
Hi @SimonBiggs, Let me take a look at the permissions. Someone outside of the organization was able to access the repo earlier this week, so I'm not sure what the issue is. I'll also look into the possibility of creating an open fork on Github. Thanks I created a fork at https://code.ornl.gov/3t6/fresco that should be completely open. Check it out and let me know if you encounter any issues. |
Hi @aspannaus, I can confirm that cloning is now working. But I cannot raise an issue there either: |
Hi @SimonBiggs, Apologies for the continued issue. We've got an internal ticket filed to sort this out; I'll post here once I have some resolution. Update: we're going to move the repo over to GitHub, but this won't be instantaneous. I'll update here with the new url. Thanks |
Hi @SimonBiggs, @gabeerion and @jmschrei, We've moved the repo over to: https://github.com/DOE-NCI-MOSSAIC/FrESCO/tree/JOSS to address the issue noted above about not being able to create a git issue without registering. Thanks again for your patience. |
@SimonBiggs @gabeerion how are the reviews coming? |
@jmschrei, just waiting on the following before I continue:
|
Just posting here for completeness, we updated the repository based on @gabeerion comments and suggestions. https://github.com/DOE-NCI-MOSSAIC/FrESCO/issues/1#issuecomment-1561201091 |
Thanks @aspannaus, I took a few small bites off the review this morning and have left two PRs on your repo for your review. Cheers, |
Hey @SimonBiggs, Thanks for taking a look, we'll start working on the PRs. |
Hi @SimonBiggs and @gabeerion, Just checking in on the status of the review, if there's anything else you need from us. Thanks! |
Hi, so sorry for the delay! I appreciate the ping and will work on this again tomorrow.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: aspannaus ***@***.***>
Sent: Monday, June 26, 2023 12:52:48 PM
To: openjournals/joss-reviews ***@***.***>
Cc: Gabriel Erion ***@***.***>; Mention ***@***.***>
Subject: Re: [openjournals/joss-reviews] [REVIEW]: FrESCO: Framework for Exploring Scalable Computational Oncology (Issue #5345)
Hi @SimonBiggs<https://github.com/SimonBiggs> and @gabeerion<https://github.com/gabeerion>,
Just checking in on the status of the review, if there's anything else you need from us.
Thanks!
—
Reply to this email directly, view it on GitHub<#5345 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA2QE6PWCSUCUQ3WFDVAH33XNG46BANCNFSM6AAAAAAWU3YZIQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@aspannaus I am the AEiC for this track and here to help with final steps. Apologies for the delay, I was out of the office for a bit. I have checked your repository, the paper, this review, and the archive, and have a few points the need your attention:
|
@editorialbot generate pdf |
@editorialbot generate pdf |
@aspannaus I see the DOIs seem fixed. However, are you also able to address the issue with the archiving link? ☝️ |
Hi @Kevin-Mattheus-Moerman, we are working on getting Zenodo connected to the repo and expect to have that completed by tomorrow. Thanks |
The archive link is here: https://zenodo.org/record/8325994. Let us know if there's anything else you need from us. Thanks! |
@editorialbot set 10.5281/zenodo.8325993 as archive |
Done! archive is now 10.5281/zenodo.8325993 |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@editorialbot set v0.2.4 as version |
Done! version is now v0.2.4 |
@aspannaus thanks for posting that archive link. The above checkbox set ☝️ shows some remaining action items. In particular the authors listed, the title, and the license listed for the archive need to be amended. You can do this manually. |
Hi @Kevin-Mattheus-Moerman , we've taken care of the above items. Let us know if you need anything else. Thanks again |
@aspannaus nearly there. The archive title should match the paper title |
@Kevin-Mattheus-Moerman , thanks for catching that. I've amended the software archive title to match the manuscript title. |
@aspannaus thanks. All looks good now. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Thanks to @Kevin-Mattheus-Moerman and @jmschrei for editorial assistance and @gabeerion @anupamajha1 for the constructive feedback and reviews. |
@aspannaus congratulations on this publication! Thanks for editing @jmschrei ! And a special thanks to the reviewers: @gabeerion, @anupamajha1 !! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @aspannaus (Adam Spannaus)
Repository: https://github.com/DOE-NCI-MOSSAIC/FrESCO
Branch with paper.md (empty if default branch): JOSS
Version: v0.2.4
Editor: @jmschrei
Reviewers: @gabeerion, @anupamajha1
Archive: 10.5281/zenodo.8325993
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gabeerion & @SimonBiggs, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jmschrei know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @gabeerion
📝 Checklist for @anupamajha1
The text was updated successfully, but these errors were encountered: