-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Qiskit Experiments: A Python package to characterize and calibrate quantum computers #5257
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Couldn't check the bibtex because branch name is incorrect: https://github.com/Qiskit/qiskit-experiments/tree/paper |
1 similar comment
Couldn't check the bibtex because branch name is incorrect: https://github.com/Qiskit/qiskit-experiments/tree/paper |
@editorialbot set paper as branch |
Done! branch is now paper |
@editorialbot check repository |
|
Wordcount for |
@editorialbot check references |
@editorialbot generate pdf |
|
👋 @eggerdj - thanks for your submission - I'll be the editor for it. Do you have any suggestions for reviewers? Either from your own knowledge or from this list of people who have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list)? If so, please mention their github username here (without tagging them with a |
@editorialbot assign me as editor |
Assigned! @danielskatz is now the editor |
@editorialbot add @nunezco2 as reviewer Thanks @nunezco2 for agreeing to review. Once we get one or two more reviewers, we'll start the review. |
@nunezco2 added to the reviewers list! |
Dear Daniel, after discussing with the team here are some reviewer suggestions taken from the list and other names that you may wish to consider:
|
👋 @goerz & @TejasAvinashShetty - Would either of you be willing to review this JOSS submission? |
👋 @lcapelluto & @brosand, would one of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html Overall, the JOSS review process is open and iterative, and aims at ensuring the work can be published by improving it. |
FYI @danielskatz the link to the documentation of Qiskit Experiments will change. See here: qiskit-community/qiskit-experiments#1096 it might be nice to update the link in the draft. The redirect should be permanent so the link should not break regardless. @coruscating |
👋 @eggerdj - you can change the draft if you want, then use the command |
I’d be willing to review this |
@eggerdj Is this submission a prelude to removing the note in the documentation that “This package is still under active development and it is very likely that there will be breaking API changes in future releases”? Generally, I’d consider a stable API a prerequisite for a publication about a package |
👋 @goerz - thanks, I'll add you, but I'm hoping to add a third reviewer as well before we start the review itself. |
@editorialbot add @goerz as editor |
Assigned! @goerz is now the editor |
@editorialbot assign me as editor |
Assigned! @danielskatz is now the editor |
@editorialbot add @goerz as reviewer |
@goerz added to the reviewers list! |
This is an interesting question, where JOSS has the expectation that the software is at a level where it can be released, typically above a beta stage. However, even software that has been widely used does sometimes make breaking changes in major releases. My expectation here is that the software would commit to not make many breaking changes in the future, and only doing so in major releases. Perhaps the documentation could say that? |
Yes, sure… I'm not saying they can't make any major releases in the future! :-) In my own projects, I would generally treat <1.0 releases as "I'm not quite sure yet what the appropriate API is, and I'm making changes at any time, without any concern for backward compatibility", whereas 1.0 would be "I'm pretty sure the fundamental design is sound, and I'm not going to break backwards compatibility for at least a year or two if I can help it". Going "on the record" by publishing a paper about a package would probably mean I'm ready to go to 1.0. So maybe, @eggerdj would consider this as a chance to go to 1.0 here as well. In that case, I think JOSS would even allow having a new paper if there is ever a 2.0 release with a major new (breaking) design. I know there are packages that for various reasons stay below 1.0 even if they're well-established and functionally stable, so I wouldn't consider a 1.0 release an absolute prerequisite for a publication. But it should definitely be beyond the "we're still working out the API" stage (which the message in the documentation would indicate) |
@danielskatz and @goerz this is a good point. Going forward the Qiskit deprecation policy will be applied https://qiskit.org/documentation/deprecation_policy.html. This will be explicitly stated in the Qiskit Experiments documentation qiskit-community/qiskit-experiments#1101. We believe that Qiskit Experiments is now sufficiently stable but will continue to evolve with the field of quantum computing. The policy outlined above should give users ample time to adjust to an occasional interface change. |
👋 @zachschoenfeld33 - would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html Overall, the JOSS review process is open and iterative, and aims at ensuring the work can be published by improving it. |
@danielskatz I am willing to review |
Thanks very much @TejasAvinashShetty - I'll add you, and we'll start the review |
@editorialbot add @TejasAvinashShetty as reviewer |
@TejasAvinashShetty added to the reviewers list! |
@editorialbot start review |
OK, I've started the review over in #5329. |
Submitting author: @eggerdj (Daniel Egger)
Repository: https://github.com/Qiskit/qiskit-experiments
Branch with paper.md (empty if default branch): paper
Version: 0.4.0
Editor: @danielskatz
Reviewers: @nunezco2, @goerz, @TejasAvinashShetty
Managing EiC: Daniel S. Katz
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @eggerdj. Currently, there isn't a JOSS editor assigned to your paper.
@eggerdj if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: