-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Geodata-Harvester: A Python package to jumpstart geospatial data extraction and analysis #5205
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@editorialbot add @martibosch as reviewer |
@martibosch added to the reviewers list! |
Review checklist for @lukasbeusterConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@sjsrey & @martibosch : could you please do |
It isn't clear to me how to proceed from the instructions? |
@sjsrey you mean for the JOSS review or for the package you are reviewing? If for JOSS, you need to generate the list of criteria we use, and then go through the list and check those that the submission fulfils. It's better explained there: #5205 (comment) If some parts are not fulfilled, then you write it here in this issue and you can provide a solution if you know how. We're here to help the submission be at the "JOSS level", to help the authors. |
@lukasbeuster : how is the review going on? @martibosch : could you please start your review at least generating the checklist so we know it is working? |
Hello @hugoledoux. I have to finish a project by next monday, I will get to the review on tuesday. Sorry for my delay. |
Review checklist for @martiboschConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@sjsrey are you finding your way here? Have you found how it works? Could you please type this to ensure everything is working fine for you? |
@martibosch @lukasbeuster any updates or a timeline for when you think you can work on this submission? |
Review checklist for @sjsreyConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @sebhaan, sorry for the extensive delay while processing the submission. Let me first say that I'm excited about the piece of software. I do think it has the potential you subscribe to it to ease access to EO data for researchers and will help people to get up and running with their analyses much faster than usual! That being said, I do have some feedback after testing around a little: Installation and first use:
Harvesting: I encountered a few hiccups while exploring:
Widgets:
The Paper:
That's my take for now. Looking forward to hearing your and the other reviewers' responses. Best |
Hello, sorry for the delay. Here is my review: The geodata-harvester library intends to provide a common interface to automate the access and preprocessing of a variety of geospatial and environmental data. This is indeed very convenient but I have three main (interrelated) remarks about the library:
Given the current materials (notebooks, documentation...), as an external reader/user with some expertise in the field, I understand the features that you aim to provide but I have a hard time understanding how I may use this library within my work. In my opinion, this can be improved by providing more detailed (and concise) example notebooks. The SIH-AgReFed Workshop materials give a more thorough overview but may be overwhelming for someone who is just checking out the library. In any case, I am looking forward to this moving forward. I will finish the other points in the checklist on monday. Best, |
Regarding the checklist: General checks
Functionality
Documentation
Software paper
That is it for my review. Looking forward to the authors responses. Best, |
A final note which I forgot: when I install geodata-harvester from conda-forge, I get a |
Hi @martibosch and @lukasbeuster, |
@editorialbot generate pdf |
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4564, then you can now move forward with accepting the submission by compiling again with the command |
Ok final steps:
|
@sebhaan |
@editorialbot generate pdf |
@kthyng |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @sebhaan! Many thanks to editor @hugoledoux and reviewers @lukasbeuster and @martibosch for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @sebhaan (Sebastian Haan)
Repository: https://github.com/Sydney-Informatics-Hub/geodata-harvester
Branch with paper.md (empty if default branch):
Version: v1.1.2
Editor: @hugoledoux
Reviewers: @lukasbeuster, @martibosch
Archive: 10.5281/zenodo.8339817
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@lukasbeuster & @sjsrey, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @lukasbeuster
📝 Checklist for @martibosch
📝 Checklist for @sjsrey
The text was updated successfully, but these errors were encountered: