-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: XGI: A Python package for higher-order interaction networks #5162
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @arashbmConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @tbsextonConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Thanks for the submission. I have already found the software to be quite useful. The paper is, in my opinion, concise and well-written. The documentation and tests are in quite a good shape, especially considering that the project is in heavy, active development by multiple contributors. I congratulate the team and wholeheartedly recommend the publication of the paper. |
Review checklist for @MridulSConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Just a quick note that we renamed our organization to be more concise, so now the repo is located at https://github.com/xgi-org/xgi in case the prior link stops working. |
Hi, @tbsexton @MridulS any news from your reviews? |
@vissarion Will be able to finish up shortly, maybe in the next few days. Apologies for the delay, I had wrapped up another JOSS review and then things got quite busy. |
Thanks for the ping @vissarion and sorry for the delay! I have finished the review and this paper should definitely be included in JOSS! The paper is well written and the package and documentation covers all the necessary details. There could be a some more information about things like "How to contribute", as currently it still leaves a lot to the reader. But I think this is good to go :) We (NetworkX) have also been thinking about how to interact with HyperGraphs in the future so this was a fun read! |
@tbsexton we now have 2 positive reviews. I generally want to wait for your review too but if this is an issue we can move forward without it. What do you think? Is it possible that you will have your review ready in the next, say 2-3, days? |
That should be fine, thanks. |
@editorialbot remove @tbsexton from reviewers |
@tbsexton removed from the reviewers list! |
@tbsexton I have removed you from reviewers to continue with this submission in a timely manner. Thanks for your time spend in this submission. @MridulS @arashbm Thank you for your reviews! @nwlandry When a submission is ready to be accepted, we ask that the authors to issue a new tagged release of the software (if changed), and archive it (see this guide). Please do this and post the version number and archive DOI in this thread. |
@editorialbot generate pdf |
@editorialbot check references |
Thanks @vissarion, references should be all fixed now. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4240, then you can now move forward with accepting the submission by compiling again with the command |
👋 @nwlandry - I'm the track editor, finishing the processing for this submission. I've found some minor issues in the bib, as shown in xgi-org/xgi#364 - please merge this, or let me know what you disagree with. In addition, I wonder if "which model" in the first sentence of the paper should be "which models"? I can't tell if this refers to the networks or the library, so both could be correct. |
I will think of how to re-write the first sentence. Thanks for noticing. |
@danielskatz I hopefully addressed the ambiguity of the first sentence and I merged in your PR fixing the references. Let me know if there is anything else I can provide. Thanks so much! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4241, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Great, thank you! This closes #5162 |
@danielskatz, I checked the tagged pull request and PDF and everything looks great. Good to close this issue now. Thanks! |
Congratulations to @nwlandry (Nicholas Landry) and co-authors!! And thanks to @arashbm and @MridulS for reviewing, and to @vissarion for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @nwlandry (Nicholas Landry)
Repository: https://github.com/ComplexGroupInteractions/xgi
Branch with paper.md (empty if default branch): paper
Version: v0.6
Editor: @vissarion
Reviewers: @arashbm, @MridulS
Archive: 10.5281/zenodo.7939055
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@arashbm & @MridulS & @tbsexton, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @vissarion know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @arashbm
📝 Checklist for @tbsexton
📝 Checklist for @MridulS
The text was updated successfully, but these errors were encountered: