Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: MD-SAPT: Python Based Toolkit for Running Symmetry Adapted Perturbation Theory Calculations on Molecular Dynamics Trajectories #5141

Closed
editorialbot opened this issue Feb 9, 2023 · 43 comments
Closed

[PRE REVIEW]: MD-SAPT: Python Based Toolkit for Running Symmetry Adapted Perturbation Theory Calculations on Molecular Dynamics Trajectories #5141

editorialbot opened this issue Feb 9, 2023 · 43 comments
Assignees
@arfon @wiederm @CarvFS
Labels
Dockerfile pre-review Shell TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 9, 2023 •
edited
Loading

Submitting author: @armcdona (Ashley Ringer McDonald)
Repository: https://github.com/calpolyccg/MDSAPT
Branch with paper.md (empty if default branch): JOSS_Pub
Version: v2.0
Editor: @arfon
Reviewers: @wiederm, @CarvFS
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/baf524e08bec6dcbd6f57a0e9b6236b9"><img src="https://joss.theoj.org/papers/baf524e08bec6dcbd6f57a0e9b6236b9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/baf524e08bec6dcbd6f57a0e9b6236b9/status.svg)](https://joss.theoj.org/papers/baf524e08bec6dcbd6f57a0e9b6236b9)

Author instructions

Thanks for submitting your paper to JOSS @armcdona. Currently, there isn't a JOSS editor assigned to your paper.

@armcdona if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Feb 9, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.09 s (667.9 files/s, 74431.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          21            876           1707           2433
XML                              1              0              0            463
YAML                            14             59            120            380
Markdown                        10             99              1            297
TeX                              1             13              0            201
reStructuredText                 8             57             75             57
Bourne Shell                     3              8             10             43
JSON                             2              5              0             42
DOS Batch                        1              8              1             27
make                             1              4              6             10
Dockerfile                       1              4             12              3
-------------------------------------------------------------------------------
SUM:                            63           1133           1932           3956
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1255

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1021/acs.jcim.8b00989 is OK
- 10.1093/bioinformatics/btx789 is OK
- 10.1063/5.0006002 is OK
- 10.1002/jcc.21787 is OK
- 10.25080/Majora-629e541a-00e is OK
- 10.1002/jcc.23753 is OK
- 10.1002/wcms.1452 is OK
- 10.6084/M9.FIGSHARE.17156018.V1 is OK
- 10.1002/wcms.84 is OK
- 10.1021/bk-2007-0958 is OK
- 10.1002/9780470399545.ch1 is OK
- 10.1016/j.bpj.2015.08.015 is OK
- 10.6084/m9.figshare.20520726.v1 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@armcdona
Copy link

Possible reviewers: tluchko, FoleyLab, cadalyjr

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @jarvist as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@jarvist
Copy link

jarvist commented Feb 13, 2023

@editorialbot assign @jarvist as editor

Perfect fit to my area! Thank you for the reviewer suggestions @armcdona Ashley.

@editorialbot
Copy link
Collaborator Author

Assigned! @jarvist is now the editor

@Kevin-Mattheus-Moerman
Copy link
Member

@jarvist hope you are doing well. Thanks for editing this one. Are you able to recruit reviewers here? Let me know if you need help.

@jarvist
Copy link

jarvist commented Mar 23, 2023 via email

@Kevin-Mattheus-Moerman
Copy link
Member

@armcdona see the request from the editor ☝️ @jarvist. Do you think you can help suggest some potential reviewers? If you have some in mind, please mention them here but leave out the @ symbol, so they are not tagged. Thanks!

@Kevin-Mattheus-Moerman
Copy link
Member

@jarvist any luck finding reviewers yourself?

@Kevin-Mattheus-Moerman
Copy link
Member

@jarvist 👋

@arfon
Copy link
Member

arfon commented Oct 1, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

pyscal: A python module for structural analysis of atomic environments
Submitting author: @srmnitc
Handling editor: @melissawm (Active)
Reviewers: @lucydot, @bocklund
Similarity score: 0.8347

BioSimSpace: An interoperable Python framework for biomolecular simulation
Submitting author: @lohedges
Handling editor: @will-rowe (Retired)
Reviewers: @amritagos, @richardjgowers
Similarity score: 0.8315

polypy - Analysis Tools for Solid State Molecular Dynamics and Monte Carlo Trajectories
Submitting author: @symmy596
Handling editor: @richardjgowers (Active)
Reviewers: @hmacdope, @lscalfi
Similarity score: 0.8312

pyCADMium: Chemical Atoms in Diatomic Molecules. A prolate spheroidal Python module for embedding calculations
Submitting author: @VHchavez
Handling editor: @lucydot (Active)
Reviewers: @raghurama123, @srmnitc
Similarity score: 0.8293

Sapsan: Framework for Supernovae Turbulence Modeling with Machine Learning
Submitting author: @pikarpov-lanl
Handling editor: @dfm (Active)
Reviewers: @kburns, @milescranmer
Similarity score: 0.8275

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@arfon
Copy link
Member

arfon commented Oct 1, 2023

@armcdona – my apologies it has taken so long to get this submission moving. Can you confirm you're still interested in pursuing this submission with JOSS?

@armcdona
Copy link

armcdona commented Oct 2, 2023

Yes, we would like to continue with the submission. My suggested reviewers were provided above in the message from 10 February 2023.

@arfon
Copy link
Member

arfon commented Oct 3, 2023

Thanks for confirming. I'll take this one on @Kevin-Mattheus-Moerman @jarvist.

@arfon
Copy link
Member

arfon commented Oct 3, 2023

@editorialbot assign me as editor

@editorialbot editorialbot assigned arfon and unassigned jarvist Oct 3, 2023
@editorialbot
Copy link
Collaborator Author

Assigned! @arfon is now the editor

@arfon
Copy link
Member

arfon commented Oct 3, 2023 •
edited
Loading

@tluchko, @FoleyLab,@cadalyjr @lohedges @symmy596 @hmacdope @lscalfi – :wave: would any of you be willing to review this submission for JOSS? The submission under consideration isMD-SAPT: Python Based Toolkit for Running Symmetry Adapted Perturbation Theory Calculations on Molecular Dynamics Trajectories – https://github.com/calpolyccg/MDSAPT

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. You can learn more about the process in these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

Based on your experience, we think you might be able to provide a great review of this submission. Please let me know if you think you can help us out!

Many thanks
Arfon

@hmacdope
Copy link

hmacdope commented Oct 3, 2023

@arfon I will have to excuse myself on the basis of a COI, as I am an MDAnalysis core-developer (creators of the MDAKit ecosystem, which this package is a member of 😄 ), and have worked with Alia (the first author) in an open source capacity as a member of our dev community a few times. I believe this falls under the COI policy but you can correct me if I am wrong. 👍

@arfon
Copy link
Member

arfon commented Oct 3, 2023

Got it. Thanks @hmacdope – I think it's best to avoid that conflict if we can yes. If you have any other folks you would recommend as potential reviewers, please let me know!

@hmacdope
Copy link

hmacdope commented Oct 3, 2023 •
edited
Loading

@wiederm expressed some interest 👍 He may need to sign up to be a reviewer before I can ping him. I can't spell.

@arfon
Copy link
Member

arfon commented Oct 3, 2023

👋 @wiederm – would you be willing to review this submission for JOSS? The submission under consideration isMD-SAPT: Python Based Toolkit for Running Symmetry Adapted Perturbation Theory Calculations on Molecular Dynamics Trajectories – https://github.com/calpolyccg/MDSAPT

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. You can learn more about the process in these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

Based on your experience, we think you might be able to provide a great review of this submission. Please let me know if you think you can help us out!

Many thanks
Arfon

@wiederm
Copy link

wiederm commented Oct 3, 2023

Hi @arfon and @hmacdope ,
happy to review this manuscript!

@arfon
Copy link
Member

arfon commented Oct 3, 2023

Amazing, thanks @wiederm! I'll wait for a second reviewer to accept before opening the main review issue. Hopefully this won't take more than a couple of days.

@tluchko
Copy link

tluchko commented Oct 3, 2023

@afron, I'm sorry but I can't. I'm over committed right now and wouldn't be able to complete the review in a timely manner.

@lohedges
Copy link

lohedges commented Oct 4, 2023

I also don't have the bandwidth right now, I'm afraid. Thanks for the consideration.

@arfon
Copy link
Member

arfon commented Oct 6, 2023

@tluchko @lohedges – are there any people you could recommend that might be able to contribute a review?

@tluchko
Copy link

tluchko commented Oct 6, 2023

@CarvFS would be a good choice. He is a postdoc in my group, if that matters.

@arfon
Copy link
Member

arfon commented Oct 8, 2023

👋 @CarvFS – would you be willing to review this submission for JOSS? The submission under consideration ishttps://github.com//issues/5141 – https://github.com/calpolyccg/MDSAPT

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. You can learn more about the process in these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

Based on your experience, we think you might be able to provide a great review of this submission. Please let me know if you think you can help us out!

Many thanks
Arfon

@CarvFS
Copy link

CarvFS commented Oct 9, 2023 via email

@arfon
Copy link
Member

arfon commented Oct 9, 2023

@editorialbot add @wiederm as reviewer

@editorialbot
Copy link
Collaborator Author

@wiederm added to the reviewers list!

@arfon
Copy link
Member

arfon commented Oct 9, 2023

@editorialbot add @CarvFS as reviewer

@editorialbot
Copy link
Collaborator Author

@CarvFS added to the reviewers list!

@arfon
Copy link
Member

arfon commented Oct 9, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5931.

@arfon
Copy link
Member

arfon commented Oct 9, 2023

@wiederm, @CarvFS, @armcdona – see you over in #5931 where the actual review will take place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arfon arfon

@wiederm wiederm

@CarvFS CarvFS

Labels
Dockerfile pre-review Shell TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@arfon @jarvist @lohedges @armcdona @Kevin-Mattheus-Moerman @hmacdope @tluchko @wiederm @editorialbot @CarvFS