Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ewstools: A Python package for early warning signals of bifurcations in time series data #5012

Closed
editorialbot opened this issue Dec 14, 2022 · 51 comments
Assignees
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Dec 14, 2022

Submitting author: @ThomasMBury (Thomas M Bury)
Repository: https://github.com/ThomasMBury/ewstools
Branch with paper.md (empty if default branch):
Version: 2.1.0
Editor: @osorensen
Reviewers: @mhu48, @mikesha2, @ranzhengcode
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/72d1a4bf216c2a4b22edab3b8f1feae0"><img src="https://joss.theoj.org/papers/72d1a4bf216c2a4b22edab3b8f1feae0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/72d1a4bf216c2a4b22edab3b8f1feae0/status.svg)](https://joss.theoj.org/papers/72d1a4bf216c2a4b22edab3b8f1feae0)

Author instructions

Thanks for submitting your paper to JOSS @ThomasMBury. Currently, there isn't a JOSS editor assigned to your paper.

@ThomasMBury if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Dec 14, 2022
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.10 s (297.4 files/s, 210492.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           9            862           1251           1230
XML                              6              0              0            605
Markdown                         3             92              0            234
Jupyter Notebook                 4              0          17125            162
TeX                              1             25              0            148
YAML                             4             10              5             45
reStructuredText                 2             34             20             36
DOS Batch                        1              8              1             26
make                             1              4              6              9
-------------------------------------------------------------------------------
SUM:                            31           1035          18408           2495
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 845

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.15681 is OK

MISSING DOIs

- 10.1098/rsif.2020.0482 may be a valid DOI for title: Detecting and distinguishing tipping points using spectral early warning signals
- 10.1371/journal.pone.0041010 may be a valid DOI for title: Methods for detecting early warnings of critical transitions in time series illustrated using simulated ecological data
- 10.1111/2041-210x.13058 may be a valid DOI for title: Monitoring ecosystem degradation using spatial data and the R package spatialwarnings
- 10.25080/majora-92bf1922-00a may be a valid DOI for title: Data structures for statistical computing in Python
- 10.25080/majora-92bf1922-011 may be a valid DOI for title: statsmodels: Econometric and statistical modeling with Python
- 10.23919/mipro.2019.8757088 may be a valid DOI for title: An overview and comparison of free Python libraries for data mining and big data analysis

INVALID DOIs

- None

@danielskatz
Copy link

@ThomasMBury - I'm the track editor for this submission, and will now look for an editor for it. While I do so, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@danielskatz
Copy link

👋 @galessiorob - would you be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @galessiorob as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@ThomasMBury
Copy link

Hi @danielskatz, thanks for helping with this. I've checked the 'missing DOIs' and they are correct for the papers I wish to cite. There is just one reference that I have removed from the bib file as I don't cite it in the paper.

Potential reviewers from the JOSS list could be
[email protected]
[email protected]
[email protected]
[email protected]

@ThomasMBury
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.15681 is OK

MISSING DOIs

- 10.1098/rsif.2020.0482 may be a valid DOI for title: Detecting and distinguishing tipping points using spectral early warning signals
- 10.1371/journal.pone.0041010 may be a valid DOI for title: Methods for detecting early warnings of critical transitions in time series illustrated using simulated ecological data
- 10.1111/2041-210x.13058 may be a valid DOI for title: Monitoring ecosystem degradation using spatial data and the R package spatialwarnings
- 10.25080/majora-92bf1922-00a may be a valid DOI for title: Data structures for statistical computing in Python
- 10.25080/majora-92bf1922-011 may be a valid DOI for title: statsmodels: Econometric and statistical modeling with Python

INVALID DOIs

- None

@ThomasMBury
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

danielskatz commented Dec 14, 2022

@ThomasMBury - there are still 5 possible DOIs that @editorialbot thinks should be added to bibtex records - are you saying that none of these are correct?

@ThomasMBury
Copy link

@danielskatz - the DOIs suggested by the bot are actually all correct. My .bib file does not contain any DOI entries - should I include the DOIs for each paper?

@danielskatz
Copy link

yes

@ThomasMBury
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/nature08227 is OK
- 10.1111/ele.12948 is OK
- 10.1098/rsif.2020.0482 is OK
- 10.1073/pnas.2106140118 is OK
- 10.1371/journal.pone.0041010 is OK
- 10.1111/2041-210X.13058 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.5281/zenodo.15681 is OK
- 10.25080/Majora-92bf1922-011 is OK
- 10.1038/s41592-020-0772-5 is OK
- 10.48550/arXiv.1605.08695 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@ThomasMBury
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/nature08227 is OK
- 10.1111/ele.12948 is OK
- 10.1098/rsif.2020.0482 is OK
- 10.1073/pnas.2106140118 is OK
- 10.1371/journal.pone.0041010 is OK
- 10.1111/2041-210X.13058 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.5281/zenodo.15681 is OK
- 10.25080/Majora-92bf1922-011 is OK
- 10.1038/s41592-020-0772-5 is OK
- 10.48550/arXiv.1605.08695 is OK

MISSING DOIs

- 10.1163/1574-9347_bnp_e612900 may be a valid DOI for title: Keras

INVALID DOIs

- None

@ThomasMBury
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/nature08227 is OK
- 10.1111/ele.12948 is OK
- 10.1098/rsif.2020.0482 is OK
- 10.1073/pnas.2106140118 is OK
- 10.1371/journal.pone.0041010 is OK
- 10.1111/2041-210X.13058 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.5281/zenodo.15681 is OK
- 10.25080/Majora-92bf1922-011 is OK
- 10.1038/s41592-020-0772-5 is OK
- 10.48550/arXiv.1605.08695 is OK

MISSING DOIs

- 10.1163/1574-9347_bnp_e612900 may be a valid DOI for title: Keras

INVALID DOIs

- None

@ThomasMBury
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/nature08227 is OK
- 10.1111/ele.12948 is OK
- 10.1098/rsif.2020.0482 is OK
- 10.1073/pnas.2106140118 is OK
- 10.1371/journal.pone.0041010 is OK
- 10.1111/2041-210X.13058 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.5281/zenodo.15681 is OK
- 10.25080/Majora-92bf1922-011 is OK
- 10.1038/s41592-020-0772-5 is OK
- 10.48550/arXiv.1605.08695 is OK

MISSING DOIs

- 10.1163/1574-9347_bnp_e612900 may be a valid DOI for title: Keras

INVALID DOIs

- None

@ThomasMBury
Copy link

@danielskatz, I'm not able to find a DOI for the Keras software - I don't think it has one. Any suggestions?

The current bibtex entry for it is
@software{chollet2015keras,
title={Keras},
author={Chollet, Fran\c{c}ois and others},
year={2015},
publisher={GitHub},
howpublished={\url{https://github.com/fchollet/keras}},
}

@danielskatz
Copy link

that's fine - this is an example where editorialbot is wrong, so you don't need to add a DOI. JOSS does want DOIs where they exist, as they can be used as an index that leads to better citation tracking.

@ThomasMBury
Copy link

Ok sounds good, thank you.

@danielskatz
Copy link

👋 @galessiorob - do you think you will be able to edit this submission?

#5012 (comment)

@danielskatz
Copy link

👋 @galessiorob - would you be able to edit this submission? (re-asking after the holiday break)

@galessiorob
Copy link

Hi @danielskatz! Unfortunately, I can't take this paper on due to tight bandwidth. Thanks for the invite, though!

@danielskatz
Copy link

👋 @osorensen - would you be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @osorensen as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@osorensen
Copy link
Member

@editorialbot add @osorensen as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @osorensen is now the editor

@osorensen
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@osorensen
Copy link
Member

👋 @ranzhengcode @vipinagrawal25 @mikesha2 @mhu48, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@mhu48
Copy link

mhu48 commented Jan 4, 2023 via email

@mikesha2
Copy link

mikesha2 commented Jan 4, 2023

👋 @ranzhengcode @vipinagrawal25 @mikesha2 @mhu48, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

I would be happy to review this submission!

Mike

@osorensen
Copy link
Member

Thanks @mhu48! Once I start the review issue you will be notified and get a link. It might take a day or two.

@osorensen
Copy link
Member

@editorialbot add @mhu48 as reviewer

@editorialbot
Copy link
Collaborator Author

@mhu48 added to the reviewers list!

@osorensen
Copy link
Member

@editorialbot add @mikesha2 as reviewer

@editorialbot
Copy link
Collaborator Author

@mikesha2 added to the reviewers list!

@ranzhengcode
Copy link

ranzhengcode commented Jan 4, 2023 via email

@osorensen
Copy link
Member

@editorialbot add @ranzhengcode as reviewer

@editorialbot
Copy link
Collaborator Author

@ranzhengcode added to the reviewers list!

@osorensen
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

8 participants