-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PCRedux: A Quantitative PCR Machine Learning Toolkit #4407
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋🏼 @devSJR, @jaybee84, @markziemann - this is the review thread for the submission. All of our communications will happen here from now on. Please check the post at the top of the issue for instructions on how to generate your own review checklist. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues directly in the software repository. If you do so, please mention this thread so that a link is created (and I can keep an eye on what is happening). Please also feel free to comment and ask questions in this thread. It is often easier to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. Please feel free to ping me (@csoneson) if you have any questions or concerns. Thanks! |
@csoneson, editorialbot found two MISSING DOIs
The bot is right. We cited the packages without the DOIs of the articles of the R Journal. We will correct this accordingly. |
@editorialbot generate pdf |
Done |
@csoneson, I have found a duplication of a citation (R Core Team). This is fixed now. |
@editorialbot generate pdf |
👋🏻 @jaybee84, @markziemann - just wanted to check in on your reviews. Note that you each need to generate your own review checklist (see instructions above). Let me know if you have any questions! |
Review checklist for @jaybee84Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@csoneson I noticed in the checklist under General checks the entry "License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?" So far the LICENSE (MIT) was stated in the DESCRIPTION file. However, there was no LICENSE text. I have added the text from https://opensource.org/licenses/MIT |
Review checklist for @markziemannConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@csoneson Checklist is complete. All good from my end. Great piece of work. |
Thank you @markziemann 🙂 |
👋🏻 @jaybee84 - could you update us on the status of your review? Thanks! |
@csoneson Apologies for the delayed response due to conference related travel. I should be able to complete this review by the end of the week. Thanks for your patience. |
@jaybee84 - just a gentle reminder of your review here. Thanks! |
@editorialbot generate pdf |
@csoneson, finally here are the missing bits. version tag of the archived version: 1.1-2 |
@editorialbot check references |
|
@editorialbot set 10.5281/zenodo.7009124 as archive |
Done! Archive is now 10.5281/zenodo.7009124 |
@editorialbot set 1.1-2 as version |
Done! version is now 1.1-2 |
@devSJR Thanks! I'll hand over now to an associate EiC for the final steps. Thanks for submitting to JOSS! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3454, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@jaybee84, @markziemann – many thanks for your reviews here and to @csoneson for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @devSJR – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@arfon @jaybee84 @markziemann @csoneson Thanks! |
Submitting author: @devSJR (Stefan Rödiger)
Repository: https://github.com/PCRuniversum/PCRedux
Branch with paper.md (empty if default branch):
Version: 1.1-2
Editor: @csoneson
Reviewers: @jaybee84, @markziemann
Archive: 10.5281/zenodo.7009124
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jaybee84 & @markziemann, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @csoneson know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @jaybee84
📝 Checklist for @markziemann
The text was updated successfully, but these errors were encountered: