Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: UncertainSCI: A Python Package for Noninvasive Parametric Uncertainty Quantification of Simulation Pipelines #4249

Closed
editorialbot opened this issue Mar 17, 2022 · 95 comments
Assignees
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 17, 2022

Submitting author: @jessdtate (Jess Tate)
Repository: https://github.com/SCIInstitute/UncertainSCI
Branch with paper.md (empty if default branch):
Version: v1.0
Editor: @kellyrowland
Reviewers: @shahmoradi, @RichardClayton, @kellyrowland
Archive: 10.5281/zenodo.8226383

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/660d2fe53fbf67dd2714e9546251bd33"><img src="https://joss.theoj.org/papers/660d2fe53fbf67dd2714e9546251bd33/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/660d2fe53fbf67dd2714e9546251bd33/status.svg)](https://joss.theoj.org/papers/660d2fe53fbf67dd2714e9546251bd33)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@shahmoradi & @RichardClayton, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kellyrowland know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @shahmoradi

📝 Checklist for @RichardClayton

📝 Checklist for @kellyrowland

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.14 s (656.3 files/s, 86275.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          51           2503           2383           4928
Markdown                        13            311              0            644
TeX                              2             21              0            217
YAML                             3              8              8             97
reStructuredText                11            113            151             87
Ruby                             1             20              6             83
DOS Batch                        1              8              1             26
CSS                              1              7              0             23
JavaScript                       2              4              0             17
make                             1              4              7              9
Bourne Shell                     2              1              0              7
HTML                             1              0              0              5
-------------------------------------------------------------------------------
SUM:                            89           3000           2556           6143
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1182

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/cnm.3395 is OK
- 10.1007/s10439-011-0391-5 is OK
- 10.1109/iembs.2005.1615736 is OK
- 10.1007/978-3-030-78710-3_49 is OK
- 10.22489/CinC.2020.275 is OK
- 10.23919/cinc53138.2021.9662950 is OK
- 10.23919/cinc53138.2021.9662837 is OK
- 10.1016/j.brs.2021.10.226 is OK
- 10.1137/17M1140960 is OK
- 10.5802/smai-jcm.24 is OK
- 10.1553/etna_vol50s71 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kellyrowland
Copy link

Hi @shahmoradi & @RichardClayton - just a reminder ping to start on your reviews when you can. Please feel free to @ me if you have any questions or run into any issues!

@kellyrowland
Copy link

Hi @RichardClayton @shahmoradi - a reminder to start on this review when you are able to. If you're unable to conduct the review, please let me know so that I can find another reviewer.

@RichardClayton
Copy link

RichardClayton commented Apr 12, 2022

Review checklist for @RichardClayton

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/SCIInstitute/UncertainSCI?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@jessdtate) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@shahmoradi
Copy link

How can I generate the checklist?

@danielskatz
Copy link

You need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

@shahmoradi
Copy link

shahmoradi commented Apr 13, 2022

Review checklist for @shahmoradi

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/SCIInstitute/UncertainSCI?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@jessdtate) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@kellyrowland
Copy link

Hi @shahmoradi @RichardClayton thanks for getting started on your reviews - just checking in; please let me know if you have any questions or concerns.

@RichardClayton
Copy link

RichardClayton commented May 3, 2022 via email

@kellyrowland
Copy link

Hi @RichardClayton - I'm really sorry to hear that, and I hope your recovery is progressing along as well as it can.

For more lengthy suggestions or requests, we suggest that reviewers open issues in the code's Github repository. So, you'll want to navigate to the issues page at https://github.com/SCIInstitute/UncertainSCI/issues and create new issues there for suggestions or requests. It can be helpful to link to those issues here in this review issue as well, to keep track of things.

@RichardClayton
Copy link

Apologies that I have taken so long to complete my initial review.

I am content to check off most of the boxes for my review. However, there are some minor revisions that I would suggest. These are:

Functionality documentation - The documentation at https://uncertainsci.readthedocs.io/en/latest/api_docs/index.html is of good quality, and there are some nice demos and tutorials, which enable the user to understand how the API works. However I would like to have seen a more comprehensive documentation of the different functions, so that users can quickly find what they are looking for without trawling through the source code.

State of the field - The paper is well written, and commendably short. However, I would like to have seen some reference to other methods for UQ aside from polynomial chaos expansions.

Either in the paper or in the documentation, it would also be very helpful to include a worked example or demo of a non-intrusive UQ exercise with an existing simulator that is not built in to UncertainSCI -- maybe by expanding Figure 1 in the paper. My guess is that most users will wish to deploy UncertainSCI on this type of code, and so this type of example would be expected to improve the use experience.

Best wishes,

Richard

@kellyrowland
Copy link

@RichardClayton thank you for the thorough review! I understand that just about everyone is stretched quite thin these days, and the JOSS team really appreciates the effort of reviewers.

@shahmoradi checking in again on your review status - please let me know about an update when you can. If you need to set down the review for any reason, please just let me know that so I can find another reviewer.

@shahmoradi
Copy link

Apologies for my delayed response. The mentions of this thread has apparently been mixed and overlooked among many other daily github emails.

  • Overall the package looks good, presents substantial work that would merit publication in JOSS. However, there are still a few major issues that need authors' attention, some of which have been also raised by @RichardClayton:
  • The documentation is very and looks beautiful, but there are parts that are still left as "TODO", or parts that are outdated, for example, the folder demo is mentioned a few times in the documentation, while apparently the corresponding folder in GitHub was later renamed to demos. Consequently, some of the commands in the documentation are non-functional. Some of the examples also appear to be non-functional. Could these examples be converted to Jupyter notebooks ready to run (instead of appearing in the documentation of the library)?
  • The paper is well-written. There is a typo in section "Statement of the need" @ "...UncertainSCI has been use to quantify..." : use --> used
  • A discussion of the "state of the field" and existing similar work appears to be missing in the paper. If there is no comparable work, the authors could simply and proudly state that UncertainCI is the first of its kind ever to exist.
  • There is a documentation section named "Developer documentation", which is essential to have, but it is mainly or only focused on guidelines for tutorials. JOSS requires guidelines for all categories of interested people including those who want to: 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support.
  • There appears to be several tests in the GitHub respoitory. But I could not find out how I could run the tests. More importantly, there is no coverage report informing the users about the tested percentage of the codebase. This is crucial to bring confidence and reliability with using this software. Ideally the tests and coverage reports should be automated with test results continuously daily reported on the project's front page on GitHub. There are several free code coverage services available that the authors could use, that particularly provide excellent service to the Python community.

I have left the three relevant items in the checklist unmarked for now until I receive the authors' response.

Sincerely

@kellyrowland
Copy link

hi @jessdtate 👋 checking in on any updates toward review completion if you have them.

@jessdtate
Copy link

Thanks for checking up @kellyrowland. We are working on implementing the changes suggested by the reviewers.

Do we need to worry about paper length if we add a little more on other methods and software?

@kellyrowland
Copy link

Thanks for the update - the suggested mark is around 1000 words, but that's flexible. Adding more material to round out the paper should be fine, but I'd be a little wary of, say, anything approaching 1500 words.

@kellyrowland
Copy link

Hi @openjournals/joss-eics @jessdtate @shahmoradi @RichardClayton - I just wanted to let you all know that I will be out of office and not checking emails, Github, etc. starting September 10 and will be returning on October 3. Happy to field any questions through the end of the week.

@editorialbot editorialbot added the Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences label Sep 10, 2022
@kellyrowland
Copy link

Hi @jessdtate -checking in here to ask if you think the paper is ready for another look by the reviewers? I see some recent commits in the joss_feedback branch and just wanted to touch base.

@oliviaguest
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/cnm.3395 is OK
- 10.1007/s10439-011-0391-5 is OK
- 10.1109/iembs.2005.1615736 is OK
- 10.1007/978-3-030-78710-3_49 is OK
- 10.22489/CinC.2020.275 is OK
- 10.23919/cinc53138.2021.9662950 is OK
- 10.23919/cinc53138.2021.9662837 is OK
- 10.1109/TMI.2015.2464315 is OK
- 10.1016/j.brs.2021.10.226 is OK
- 10.1007/978-3-540-28650-9_4 is OK
- 10.1137/17M1140960 is OK
- 10.5802/smai-jcm.24 is OK
- 10.1553/etna_vol50s71 is OK

MISSING DOIs

- 10.1007/978-3-319-10470-6_66 may be a valid DOI for title: Variational Bayesian electrophysiological imaging of myocardial infarction.

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4681, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Oct 11, 2023
@oliviaguest
Copy link
Member

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/cnm.3395 is OK
- 10.1007/s10439-011-0391-5 is OK
- 10.1109/iembs.2005.1615736 is OK
- 10.1007/978-3-030-78710-3_49 is OK
- 10.22489/CinC.2020.275 is OK
- 10.23919/cinc53138.2021.9662950 is OK
- 10.23919/cinc53138.2021.9662837 is OK
- 10.1109/TMI.2015.2464315 is OK
- 10.1016/j.brs.2021.10.226 is OK
- 10.1007/978-3-540-28650-9_4 is OK
- 10.1137/17M1140960 is OK
- 10.5802/smai-jcm.24 is OK
- 10.1553/etna_vol50s71 is OK

MISSING DOIs

- 10.1007/978-3-319-10470-6_66 may be a valid DOI for title: Variational Bayesian electrophysiological imaging of myocardial infarction.

INVALID DOIs

- None

@oliviaguest
Copy link
Member

@jessdtate I think this is the correct DOI for the article?

Xu, J., Sapp, J.L., Rahimi Dehaghani, A., Gao, F., Wang, L. (2014). Variational Bayesian Electrophysiological Imaging of Myocardial Infarction. In: Golland, P., Hata, N., Barillot, C., Hornegger, J., Howe, R. (eds) Medical Image Computing and Computer-Assisted Intervention – MICCAI 2014. MICCAI 2014. Lecture Notes in Computer Science, vol 8674. Springer, Cham. https://doi.org/10.1007/978-3-319-10470-6_66

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4697, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@jessdtate
Copy link

jessdtate commented Oct 16, 2023

@oliviaguest I've made a tag of a branch with the suggested changes, v1.0.1.1. It should be merged into master soon.

@oliviaguest
Copy link
Member

oliviaguest commented Oct 16, 2023

@kellyrowland have you used the checklist for this? 😊 see below...

Edit: I see one from August! Sorry!

@oliviaguest
Copy link
Member

@jessdtate can you run check citations command when it's done, please? ☺️

@jessdtate
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/cnm.3395 is OK
- 10.1007/s10439-011-0391-5 is OK
- 10.1109/iembs.2005.1615736 is OK
- 10.1007/978-3-030-78710-3_49 is OK
- 10.22489/CinC.2020.275 is OK
- 10.23919/cinc53138.2021.9662950 is OK
- 10.23919/cinc53138.2021.9662837 is OK
- 10.1109/TMI.2015.2464315 is OK
- 10.1016/j.brs.2021.10.226 is OK
- 10.1007/978-3-319-10470-6_66 is OK
- 10.1007/978-3-319-10470-6_66 is OK
- 10.1007/978-3-540-28650-9_4 is OK
- 10.1137/17M1140960 is OK
- 10.5802/smai-jcm.24 is OK
- 10.1553/etna_vol50s71 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@oliviaguest
Copy link
Member

Thank you!!!

@oliviaguest
Copy link
Member

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/cnm.3395 is OK
- 10.1007/s10439-011-0391-5 is OK
- 10.1109/iembs.2005.1615736 is OK
- 10.1007/978-3-030-78710-3_49 is OK
- 10.22489/CinC.2020.275 is OK
- 10.23919/cinc53138.2021.9662950 is OK
- 10.23919/cinc53138.2021.9662837 is OK
- 10.1109/TMI.2015.2464315 is OK
- 10.1016/j.brs.2021.10.226 is OK
- 10.1007/978-3-319-10470-6_66 is OK
- 10.1007/978-3-319-10470-6_66 is OK
- 10.1007/978-3-540-28650-9_4 is OK
- 10.1137/17M1140960 is OK
- 10.5802/smai-jcm.24 is OK
- 10.1553/etna_vol50s71 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4729, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@oliviaguest
Copy link
Member

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Tate
  given-names: Jess
  orcid: "https://orcid.org/0000-0002-2934-1453"
- family-names: Liu
  given-names: Zexin
  orcid: "https://orcid.org/0000-0003-3409-5709"
- family-names: Bergquist
  given-names: Jake A
  orcid: "https://orcid.org/0000-0002-4586-6911"
- family-names: Rampersad
  given-names: Sumientra
  orcid: "https://orcid.org/0000-0001-9860-4459"
- family-names: White
  given-names: Dan
- family-names: Charlebois
  given-names: Chantel
  orcid: "https://orcid.org/0000-0002-4139-3539"
- family-names: Rupp
  given-names: Lindsay
  orcid: "https://orcid.org/0000-0002-2688-7688"
- family-names: Brooks
  given-names: Dana H
  orcid: "https://orcid.org/0000-0003-3231-6715"
- family-names: MacLeod
  given-names: Rob S
  orcid: "https://orcid.org/0000-0002-0000-0356"
- family-names: Narayan
  given-names: Akil
  orcid: "https://orcid.org/0000-0002-5914-4207"
doi: 10.5281/zenodo.8226383
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Tate
    given-names: Jess
    orcid: "https://orcid.org/0000-0002-2934-1453"
  - family-names: Liu
    given-names: Zexin
    orcid: "https://orcid.org/0000-0003-3409-5709"
  - family-names: Bergquist
    given-names: Jake A
    orcid: "https://orcid.org/0000-0002-4586-6911"
  - family-names: Rampersad
    given-names: Sumientra
    orcid: "https://orcid.org/0000-0001-9860-4459"
  - family-names: White
    given-names: Dan
  - family-names: Charlebois
    given-names: Chantel
    orcid: "https://orcid.org/0000-0002-4139-3539"
  - family-names: Rupp
    given-names: Lindsay
    orcid: "https://orcid.org/0000-0002-2688-7688"
  - family-names: Brooks
    given-names: Dana H
    orcid: "https://orcid.org/0000-0003-3231-6715"
  - family-names: MacLeod
    given-names: Rob S
    orcid: "https://orcid.org/0000-0002-0000-0356"
  - family-names: Narayan
    given-names: Akil
    orcid: "https://orcid.org/0000-0002-5914-4207"
  date-published: 2023-10-27
  doi: 10.21105/joss.04249
  issn: 2475-9066
  issue: 90
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 4249
  title: "UncertainSCI: A Python Package for Noninvasive Parametric
    Uncertainty Quantification of Simulation Pipelines"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.04249"
  volume: 8
title: "UncertainSCI: A Python Package for Noninvasive Parametric
  Uncertainty Quantification of Simulation Pipelines"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.04249 joss-papers#4732
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04249
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Oct 27, 2023
@oliviaguest
Copy link
Member

Huge thanks to the reviewers @shahmoradi, @RichardClayton, and also editor @kellyrowland! ✨ JOSS appreciates your work and effort. ✨ Also, big congratulations to the authors (@jessdtate)! 🥳 🍾

@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04249/status.svg)](https://doi.org/10.21105/joss.04249)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04249">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04249/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04249/status.svg
   :target: https://doi.org/10.21105/joss.04249

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences
Projects
None yet
Development

No branches or pull requests

8 participants