-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: UncertainSCI: A Python Package for Noninvasive Parametric Uncertainty Quantification of Simulation Pipelines #4249
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Hi @shahmoradi & @RichardClayton - just a reminder ping to start on your reviews when you can. Please feel free to @ me if you have any questions or run into any issues! |
Hi @RichardClayton @shahmoradi - a reminder to start on this review when you are able to. If you're unable to conduct the review, please let me know so that I can find another reviewer. |
Review checklist for @RichardClaytonConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
How can I generate the checklist? |
You need to run this command in a separate comment to create the checklist:
|
Review checklist for @shahmoradiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @shahmoradi @RichardClayton thanks for getting started on your reviews - just checking in; please let me know if you have any questions or concerns. |
Hi Kelly,
Thanks -- I am just recovering from an unpleasant bout of covid, which took
me out for 2 weeks. I am just catching up with emails and all of the other
tasks that have been piling up.
I did have a question about feedback to the authors. Is there a mechanism
to provide comments on the manuscript beyond the tickboxes on the checklist?
Best wishes,
Richard
--
…On Mon, 2 May 2022 at 17:58, Kelly L. Rowland ***@***.***> wrote:
Hi @shahmoradi <https://github.com/shahmoradi> @RichardClayton
<https://github.com/RichardClayton> thanks for getting started on your
reviews - just checking in; please let me know if you have any questions or
concerns.
—
Reply to this email directly, view it on GitHub
<#4249 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBW7NA4OGEEOJ7GSR33ORLVIACTZANCNFSM5Q7NDIRQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Professor Richard H Clayton
INSIGNEO Institute for In-Silico Medicine and
Department of Computer Science,
University of Sheffield.
|
Hi @RichardClayton - I'm really sorry to hear that, and I hope your recovery is progressing along as well as it can. For more lengthy suggestions or requests, we suggest that reviewers open issues in the code's Github repository. So, you'll want to navigate to the issues page at https://github.com/SCIInstitute/UncertainSCI/issues and create new issues there for suggestions or requests. It can be helpful to link to those issues here in this review issue as well, to keep track of things. |
Apologies that I have taken so long to complete my initial review. I am content to check off most of the boxes for my review. However, there are some minor revisions that I would suggest. These are: Functionality documentation - The documentation at https://uncertainsci.readthedocs.io/en/latest/api_docs/index.html is of good quality, and there are some nice demos and tutorials, which enable the user to understand how the API works. However I would like to have seen a more comprehensive documentation of the different functions, so that users can quickly find what they are looking for without trawling through the source code. State of the field - The paper is well written, and commendably short. However, I would like to have seen some reference to other methods for UQ aside from polynomial chaos expansions. Either in the paper or in the documentation, it would also be very helpful to include a worked example or demo of a non-intrusive UQ exercise with an existing simulator that is not built in to UncertainSCI -- maybe by expanding Figure 1 in the paper. My guess is that most users will wish to deploy UncertainSCI on this type of code, and so this type of example would be expected to improve the use experience. Best wishes, Richard |
@RichardClayton thank you for the thorough review! I understand that just about everyone is stretched quite thin these days, and the JOSS team really appreciates the effort of reviewers. @shahmoradi checking in again on your review status - please let me know about an update when you can. If you need to set down the review for any reason, please just let me know that so I can find another reviewer. |
Apologies for my delayed response. The mentions of this thread has apparently been mixed and overlooked among many other daily github emails.
I have left the three relevant items in the checklist unmarked for now until I receive the authors' response. Sincerely |
hi @jessdtate 👋 checking in on any updates toward review completion if you have them. |
Thanks for checking up @kellyrowland. We are working on implementing the changes suggested by the reviewers. Do we need to worry about paper length if we add a little more on other methods and software? |
Thanks for the update - the suggested mark is around 1000 words, but that's flexible. Adding more material to round out the paper should be fine, but I'd be a little wary of, say, anything approaching 1500 words. |
Hi @openjournals/joss-eics @jessdtate @shahmoradi @RichardClayton - I just wanted to let you all know that I will be out of office and not checking emails, Github, etc. starting September 10 and will be returning on October 3. Happy to field any questions through the end of the week. |
Hi @jessdtate -checking in here to ask if you think the paper is ready for another look by the reviewers? I see some recent commits in the |
@editorialbot generate pdf |
|
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4681, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot recommend-accept |
|
|
@jessdtate I think this is the correct DOI for the article?
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4697, then you can now move forward with accepting the submission by compiling again with the command |
@oliviaguest I've made a tag of a branch with the suggested changes, v1.0.1.1. It should be merged into master soon. |
@kellyrowland have you used the checklist for this? 😊 see below... Edit: I see one from August! Sorry! |
@jessdtate can you run check citations command when it's done, please? |
@editorialbot check references |
|
Thank you!!! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4729, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Huge thanks to the reviewers @shahmoradi, @RichardClayton, and also editor @kellyrowland! ✨ JOSS appreciates your work and effort. ✨ Also, big congratulations to the authors (@jessdtate)! 🥳 🍾 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @jessdtate (Jess Tate)
Repository: https://github.com/SCIInstitute/UncertainSCI
Branch with paper.md (empty if default branch):
Version: v1.0
Editor: @kellyrowland
Reviewers: @shahmoradi, @RichardClayton, @kellyrowland
Archive: 10.5281/zenodo.8226383
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@shahmoradi & @RichardClayton, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kellyrowland know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @shahmoradi
📝 Checklist for @RichardClayton
📝 Checklist for @kellyrowland
The text was updated successfully, but these errors were encountered: