-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: cca-zoo #3823
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @robbisg, @hugorichard, @ejolly it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Wordcount for |
|
|
Hi everyone ! 👋 Thanks again for agreeing to review this submission ! The review will take place in this issue. Whenever possible, please open relevant issues on the linked software repository (and cross-link them with this issue) rather than discussing them here. This helps to make sure that feedback is translated into actionable items to improve the software. If you aren't sure how to get started, please see the Reviewing for JOSS guide -- and, of course, feel free to ping me with any questions ! @jameschapman19, one small formatting note : It looks like your |
@whedon check references |
|
👋 @robbisg, please update us on how your review is going (this is an automated reminder). |
👋 @ejolly, please update us on how your review is going (this is an automated reminder). |
👋 @hugorichard, please update us on how your review is going (this is an automated reminder). |
Sorry for the delay, I will review the package this week. |
@emdupre, here is my review: This is a really nice piece of software. I believe it is really useful to have all these CCA methods gathered at the same place. I recommend acceptance. As a side note, I believe the vision of mvlearn and cca-zoo coincide. It would be interesting to study how to fuse the two in my opinion. A few comments:
|
Hi everyone, @emdupre I will not open an issue in the ReviewI think PaperThe paper is well written and presents an extensive comparison of other similar packages and the implementation philosophy.
SoftwareThe software uses the
I think that the tool is in a very good shape, I recommend acceptance. Thanks @jameschapman19 and @emdupre, and sorry for the delay. |
I was wary of replying as I don't know the process but it feels appropriate for me to say thanks both. All of these comments I agree with and will action them.
|
Thanks both @hugorichard and @robbisg for your reviews, and @jameschapman19 for your thoughtful response ! Please do feel free to continue discussions in thread, though as specific issues on |
👋 hi @ejolly ! I just wanted to check-in on this review. Please let me know if you're encountering any technical difficulties that I can help with, or if you have a timeline for when you expect to be able to complete this ! |
hey @emdupre sorry for the delay. I'm hoping to have this done by the end of this week or the start of next at the latest! |
Hey @emdupre @jameschapman19 here's my review: Review
Suggested Changes
Minor suggested changes
Test and Issues
|
Thanks @ejolly for your review ! It looks like jameschapman19/cca_zoo#74, jameschapman19/cca_zoo#75, jameschapman19/cca_zoo#76, and jameschapman19/cca_zoo#77 were all created in response to reviewer feedback, so I'll monitor those issues to see how the revisions are going. @hugorichard @robbisg @ejolly if there are any additional issues you noted that you consider to not be covered by those issues, please let us know here ! |
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2827 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2827, then you can now move forward with accepting the submission by compiling again with the flag
|
Hi @jameschapman19, I'm just doing some final checks before accepting. Can you capitalize "python" in the paper's title? There are some uses throughout the paper where it should be capitalized as well. Also, the Bach and Jordan reference needs a few more details. This is a technical report, published by University of California Berkeley Department of Statistics, Tech. Rep. 688. You can also add the URL https://statistics.berkeley.edu/sites/default/files/tech-reports/688.pdf. Lastly, please confirm that there are no DOIs available for the Wenwen et al. and Wong et al. references. |
Thank you for catching those points, @kyleniemeyer !
@jameschapman19, when you're making those changes please update it in the zenodo archive as well, just so those two documents match ! |
Thanks @kyleniemeyer - I was able to track down a doi for Wenwen et al. too @emdupre I made a related change to the references in the docstrings themselves so best to also change to 1.10.8 (but don't worry if it's too much trouble). |
Thank you, @jameschapman19 ! To confirm, did you also create a corresponding archive for the new release ? Can you list the DOI here if so ? |
New DOI: 10.5281/zenodo.5786616 Just realised there is also the DOI which resolves to the most recent: 10.5281/zenodo.4382739 I don't know what is more appropriate for JOSS but I'm happy with either. |
@whedon set 10.5281/zenodo.5786616 as archive We prefer the DOI that points to the specific version |
OK. 10.5281/zenodo.5786616 is the archive. |
@whedon generate pdf |
@jameschapman19 sorry, the Wenwen et al. reference still needs one final change—the DOI field should not have the extra |
🤦 fixed |
@whedon generate pdf |
@whedon set v1.10.8 as version |
OK. v1.10.8 is the version. |
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @jameschapman19 on your article's publication in JOSS! Many thanks to @robbisg, @hugorichard, and @ejolly for reviewing this submission, and @emdupre for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @jameschapman19 (James Chapman)
Repository: https://github.com/jameschapman19/cca_zoo
Version: v1.10.8
Editor: @emdupre
Reviewer: @robbisg, @hugorichard, @ejolly
Archive: 10.5281/zenodo.5786616
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@robbisg & @hugorichard & @ejolly, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @emdupre know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @robbisg
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @hugorichard
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @ejolly
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: