Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: elmada: Dynamic electricity carbon emission factors and prices for Europe #3528

Closed
whedon opened this issue Jul 23, 2021 · 32 comments

Comments

@whedon
Copy link

whedon commented Jul 23, 2021

Submitting author: @mfleschutz (Markus Fleschutz)
Repository: https://github.com/DrafProject/elmada
Version: v0.0.6
Editor: @fraukewiese
Reviewers: @nmstreethran, @olejandro
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9a6bf04b8a7bbc6b29b2ad79103acf42"><img src="https://joss.theoj.org/papers/9a6bf04b8a7bbc6b29b2ad79103acf42/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9a6bf04b8a7bbc6b29b2ad79103acf42/status.svg)](https://joss.theoj.org/papers/9a6bf04b8a7bbc6b29b2ad79103acf42)

Author instructions

Thanks for submitting your paper to JOSS @mfleschutz. Currently, there isn't an JOSS editor assigned to your paper.

@mfleschutz if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 23, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 23, 2021

Failed to discover a Statement of need section in paper

@whedon
Copy link
Author

whedon commented Jul 23, 2021

Wordcount for paper.md is 480

@whedon
Copy link
Author

whedon commented Jul 23, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.apenergy.2021.117040 is OK
- 10.5281/zenodo.5126771 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Jul 23, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.14 s (376.5 files/s, 94902.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              5              0             33           7892
Python                          33            920            423           2827
Markdown                         5            190              0            523
YAML                             4              9              4            120
HTML                             1              7              0             51
TeX                              1              5              0             45
JSON                             1              0              0             28
TOML                             1              1              1             18
INI                              1              0              2             10
-------------------------------------------------------------------------------
SUM:                            52           1132            463          11514
-------------------------------------------------------------------------------


Statistical information for the repository '9ec23e61ec74125d60b5b612' was
gathered on 2021/07/23.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
flma0001                        46          6772           2602          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
flma0001                   4170           61.6          0.9                7.22

@whedon
Copy link
Author

whedon commented Jul 23, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

👋 @fraukewiese - would you be able to edit this submission?

@danielskatz
Copy link

@whedon invite @fraukewiese as editor

@whedon
Copy link
Author

whedon commented Jul 23, 2021

@fraukewiese has been invited to edit this submission.

@arfon
Copy link
Member

arfon commented Jul 24, 2021

👋 @fraukewiese - would you be able to edit this submission?

Just an FYI that @fraukewiese is OoO until 3 August so might be a little slow to respond here :-)

@danielskatz
Copy link

I think this is still the best option for this submission.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon invite @fraukewiese as editor

@whedon
Copy link
Author

whedon commented Aug 3, 2021

@fraukewiese has been invited to edit this submission.

@fraukewiese
Copy link

Yes I can edit this paper.

@fraukewiese
Copy link

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Aug 4, 2021

OK, the editor is @fraukewiese

@fraukewiese
Copy link

@milicag , @ckaldemeyer , @nmstreethran – would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is elmada: Dynamic electricity carbon emission factors and prices for Europe

@nmstreethran
Copy link

@fraukewiese Yes, I'd be happy to review this submission.

@fraukewiese
Copy link

Great! Thanks @nmstreethran
I will add you as a reviewer now but won't actually start the review until we have a second reviewer signed up.

@fraukewiese
Copy link

@whedon add @nmstreethran as reviewer

@whedon whedon assigned fraukewiese and nmstreethran and unassigned fraukewiese Aug 6, 2021
@whedon
Copy link
Author

whedon commented Aug 6, 2021

OK, @nmstreethran is now a reviewer

@fraukewiese
Copy link

@milicag , @ckaldemeyer – would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is elmada: Dynamic electricity carbon emission factors and prices for Europe

@fraukewiese
Copy link

For information: I am contacting milicag and ckaldemeyer now per Mail to find out whether they could review, if not I will ask other reviewer.

@fraukewiese
Copy link

ckaldemeyer cannot review this (answer by Mail) and I do not receive an answer from milicag (also by Mail), so I will ask other potential reviewer now.

@fraukewiese
Copy link

@olejandro : would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission under review here is elmada: Dynamic electricity carbon emission factors and prices for Europe

@olejandro
Copy link

@fraukewiese Yes, I'd be happy to. What's the timeframe?

@fraukewiese
Copy link

Great, thanks @olejandro !
We aim for the review process to be completed within about 4-6 weeks but it is necessary to make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule.

@fraukewiese
Copy link

@whedon add @olejandro as reviewer

@whedon
Copy link
Author

whedon commented Aug 18, 2021

OK, @olejandro is now a reviewer

@fraukewiese
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Aug 18, 2021

OK, I've started the review over in #3625.

@whedon whedon closed this as completed Aug 18, 2021
@fraukewiese
Copy link

@olejandro , @nmstreethran – thanks a lot for agreeing to review here! See you over in #3625 where the actual review will take place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants