Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: GeoClimate : a Geospatial processing toolbox for environmental and climate studies #3442

Closed
whedon opened this issue Jul 1, 2021 · 40 comments

Comments

@whedon
Copy link

whedon commented Jul 1, 2021

Submitting author: @ebocher (Erwan Bocher)
Repository: https://github.com/orbisgis/geoclimate/
Version: 1.0.0-SNAPSHOT
Editor: @elbeejay
Reviewers: @abhishekvp, @omshinde, @arbennett
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2b216ea704e5ee9d61a8208463c17ce1"><img src="https://joss.theoj.org/papers/2b216ea704e5ee9d61a8208463c17ce1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2b216ea704e5ee9d61a8208463c17ce1/status.svg)](https://joss.theoj.org/papers/2b216ea704e5ee9d61a8208463c17ce1)

Author instructions

Thanks for submitting your paper to JOSS @ebocher. Currently, there isn't an JOSS editor assigned to your paper.

@ebocher if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 1, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@arfon
Copy link
Member

arfon commented Jul 1, 2021

@ebocher - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jul 1, 2021
@ebocher
Copy link

ebocher commented Jul 2, 2021

@arfon thanks for the comment. hugoledoux will be a very good candidate to review the paper.
Best regards

@kthyng
Copy link

kthyng commented Jul 14, 2021

@whedon check repo

@whedon
Copy link
Author

whedon commented Jul 14, 2021

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands

@kthyng
Copy link

kthyng commented Jul 14, 2021

@whedon check repository

@whedon
Copy link
Author

whedon commented Jul 14, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.92 s (104.1 files/s, 165298.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                              5             14             16          78777
SVG                              1              1              1          44890
Groovy                          37           1848           3232          15668
JSON                            32              5              0           4734
Scheme                           3              1              0            799
Maven                            5             29              7            761
SQL                              6            196            297            702
Markdown                         4             86              0            228
TeX                              1             11              0            147
YAML                             2              4              4             38
-------------------------------------------------------------------------------
SUM:                            96           2195           3557         146744
-------------------------------------------------------------------------------


Statistical information for the repository '79ba885c5d60828236c95119' was
gathered on 2021/07/14.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Bocher                           2             4              4            0.12
Elisabeth Le Saux                2           626            409           15.44
Palominos Sylvain                4             8             50            0.87
ebocher                         25          1389           1029           36.07
gpetit                          22          1652            343           29.76
jeremy                           1            22             22            0.66
jeremy-b                        50           604            441           15.59
nahtanojoal                      4            94              6            1.49

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
ebocher                     368           26.5          7.1                3.53
gpetit                      623           37.7         24.7               44.78
jeremy-b                    202           33.4         17.8                2.48
nahtanojoal                   2            2.1         26.5                0.00

@kthyng
Copy link

kthyng commented Jul 14, 2021

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 14, 2021

PDF failed to compile for issue #3442 with the following error:

 /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:456:in `parse': (b6385f2dafbdfd845db88e95/docs/articles/joss/paper.md): did not find expected key while parsing a block mapping at line 2 column 1 (Psych::SyntaxError)
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:456:in `parse_stream'
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:390:in `parse'
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:277:in `load'
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:578:in `block in load_file'
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:577:in `open'
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:577:in `load_file'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:127:in `load_yaml'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:87:in `initialize'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/processor.rb:38:in `new'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/processor.rb:38:in `set_paper'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/bin/whedon:58:in `prepare'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/bin/whedon:131:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `load'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `<main>'

@ebocher
Copy link

ebocher commented Jul 15, 2021

@kthyng
Just to inform you that the PDF compiles using github action : https://github.com/orbisgis/geoclimate/actions/runs/989591342

@arfon
Copy link
Member

arfon commented Jul 15, 2021

@ebocher - please remove the blank ORCID lines from your paper by merging this pull request: orbisgis/geoclimate#609

Also it looks like you're not citing your references properly. The section in your paper.md after the # References heading should be empty and citations to other works will automatically appear in there if you cite them in the paper text. You can read how to do that here

@ebocher
Copy link

ebocher commented Jul 15, 2021

thanks @arfon I will fix it

j3r3m1 added a commit to orbisgis/geoclimate that referenced this issue Jul 15, 2021
Remove all text from the reference section
Put all footnotes which were in the reference section within the article body
@j3r3m1
Copy link

j3r3m1 commented Jul 15, 2021

@ebocher - please remove the blank ORCID lines from your paper by merging this pull request: orbisgis/geoclimate#609

Done

Also it looks like you're not citing your references properly. The section in your paper.md after the # References heading should be empty and citations to other works will automatically appear in there if you cite them in the paper text. You can read how to do that here

The reason was that we put footnote in the reference section since it did not work otherwise. I removed them and add them in the body of the article but I am not sure it works as expected. You can let us know before we merge or we can merge and then see. The pull request is here:
orbisgis/geoclimate#610

@kthyng
Copy link

kthyng commented Jul 15, 2021

Hi @fraukewiese are you interested in editing this submission?

@kthyng
Copy link

kthyng commented Jul 15, 2021

@whedon invite @fraukewiese as editor

@whedon
Copy link
Author

whedon commented Jul 15, 2021

@fraukewiese has been invited to edit this submission.

@ebocher
Copy link

ebocher commented Jul 16, 2021

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 16, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@fraukewiese
Copy link

I will be OoO until beginning of August, so I would prefer if somebody else could edit this submission.

@danielskatz
Copy link

👋 @elbeejay - Would you be able to edit this submission?

@danielskatz
Copy link

@whedon invite @elbeejay as editor

@whedon
Copy link
Author

whedon commented Jul 20, 2021

@elbeejay has been invited to edit this submission.

@elbeejay
Copy link
Member

@whedon assign @elbeejay as editor

@whedon
Copy link
Author

whedon commented Jul 20, 2021

OK, the editor is @elbeejay

@elbeejay elbeejay removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jul 24, 2021
@abhishekvp
Copy link

Hi! thanks for the review invitation @elbeejay. I looked through the journal's conflict of interest policy. I declare that I do not have any conflict of interest. I hereby agree to review this submission for JOSS. Thanks!

@elbeejay
Copy link
Member

@whedon add @abhishekvp as reviewer

@whedon whedon assigned abhishekvp and elbeejay and unassigned elbeejay Jul 25, 2021
@whedon
Copy link
Author

whedon commented Jul 25, 2021

OK, @abhishekvp is now a reviewer

@omshinde
Copy link

Hi @elbeejay! Thanks for the review invitation. I confirm that I do not hold any conflict of interest for this submission and would be happy to review this submission for JOSS. Regards!

@nuest
Copy link

nuest commented Jul 26, 2021

@elbeejay Thanks for considering me - I am not able to perform a review at this point in time, as I'm taking a leave of absence until March next year.

@arbennett
Copy link

Hi @elbeejay - I would be happy to review this! I also do not hold any conflict of interest for this submission.

@elbeejay
Copy link
Member

Great, thank you all. We will move this forward to review.

@elbeejay
Copy link
Member

@whedon add @omshinde as reviewer

@whedon
Copy link
Author

whedon commented Jul 26, 2021

OK, @omshinde is now a reviewer

@elbeejay
Copy link
Member

@whedon add @arbennett as reviewer

@whedon
Copy link
Author

whedon commented Jul 26, 2021

OK, @arbennett is now a reviewer

@elbeejay
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 26, 2021

OK, I've started the review over in #3541.

@whedon whedon closed this as completed Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests