-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: covid19.analytics: An R Package to Obtain, Analyze and Visualize Data from the 2019 Corona Virus Disease Pandemic #2995
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @LogIN-, @JDRomano2 it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
PDF failed to compile for issue #2995 with the following error: Can't find any papers to compile :-( |
@whedon generate pdf from branch literature |
|
@JDRomano2 and @LogIN- - I just wanted to check on the status of your reviews. Please let me know if I can assist with anything. Thanks again! |
Thanks very much @fboehm for the invitation to review this submission! Please see below for individual comments on each of the checklist items that I feel need attention: General checksContribution and authorship: Has the submitting author (@mponce0) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?The contributions made by the second author are not clear, as they are not a contributor to the GitHub source repository, and their contributions are not described elsewhere in the paper. I would strongly recommend including information about author contributions in an "About" heading within the GitHub README, as well as current contact information for at least the primary author. DocumentationFunctionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?Documentation is provided primarily by means of examples. No API documentation is given. If a reference manual with API documentation is available on CRAN, there should be a link to it from the GitHub README and/or the project website. Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek supportI cannot find any community guidelines in the paper, the code repository, or the project's website. The process for reporting bugs and issues is especially important to include, and should be clearly defined in the README. Ideally this would make use of GitHub's issue tracking functionality. Software paperSummary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?The summary is somewhat vague and nonspecific.
What does 'approach it' mean? The paper should clearly describe the types of data-related problems that the software is meant to solve. A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?The authors do describe the motivation behind the project in the context of other open-source COVID-19 data resources. However, the "Statement of Need" section needs to be cleaned up. Much of the text in here should go either into the Summary (keeping in mind the recommended edits mentioned above) or into a separate section following the Statement of Need describing the software's functionality. The GitHub README file contains a fairly good description of the needs this software is meant to address, and some of that text can probably be reused in the paper. Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?The paper is in need of stylistic and typographical revisions. A few examples (not comprehensive) include:
These are just a few examples that stand out. References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?Some of the citations are incomplete. For example, the citation for "The Comprehensive R Archive Network" should include the journal name, author, publication date, volume, and issue number. These are easily found by clicking on the DOI link provided in the reference. Similar omissions are found in several of the other references. I'm not sure that enough of the citations point to appropriate publications or data sources. For example, you list the Visual Capitalist infographic as one of the data sources used by your software, but the linked article doesn't seem to provide any way to access the data. |
Many thanks @JDRomano2 for the thorough review and useful comments!
Authors contributions were (and are) originally described in the "Description" file, which is the standard place for doing it in R packages. Following the reviewer's recommendation we have also added an "About" heading to the README document stating more clearly the contributions of the authors, as well as the way for the community to contribute to the package.
A link has been added to the README for API documentation, in this case, functions descriptions from CRAN immediately after the
This was mentioned both in the paper as well as in the README file, in the first bullet point of "Statement of need":
We have clarified the summary and added a few sentences to describe what the package can allow users to achieve in terms of the data availability and its challenges.
We have restructured and edited the manuscript to incorporate the reviewer's comments.
We thank the reviewer for noticing this, and we have revisit and edited the manuscript to fix all of these.
We have reviewed the citations and completed the information for the CRAN publication. We couldn't identify any other reference missing any of the elements described above.
This is because the data from the infographics was gather manually, ie. no actual data repository is offered. |
@whedon generate pdf from branch literature |
|
@whedon generate pdf from branch literature |
|
👋 @JDRomano2, please update us on how your review is going. |
👋 @LogIN-, please update us on how your review is going. |
Hi @fboehm thank you for invitation for the review. Authors did a good job in developing a package, it can be successfully installed and used. Here is my opinion on what needs to be changed:
When this self-citation is removed authors should describe in more detail functionality of this R package, similar to their preprint publication, otherwise from current paper many aspects of the package will stay unclear. Maybe the best solution is to have peer review of their preprint paper and having that published in JOSS. |
@LogIN- thanks for your message. Can you clarify - is the preprint article the same (same title, same text) that is being considered here? Or does it merely have the same title? Thanks again! |
The title is the same but the pre-print article (~47 pages) is quite lengthy. When considering submitting the manuscript to JOSS we thought about it but when checking the structure and recommended format we felt that it wouldn't fit with this format. |
Hi @LogIN- , many thanks for your review and encouraging words. |
Yes, that's right, @mponce0 . The purpose of JOSS is to publish the software and, typically, we prefer short articles that discuss the software. @LogIN- I think it would be ok, and, possibly helpful, to maintain the citation to the preprint, especially considering that it's not the same as the manuscript that accompanies the software submission to JOSS. I agree, @LogIN-, with you encouraging the authors to detail functionality of the R package, while aiming to keep the JOSS manuscript length at ~ 3 pages or less. Does that seem reasonable? |
I'm certainly more inclined to keep the JOSS paper short, we are already at 5 pages (a bit above 3 without including references). @fboehm There are two main issues with adding the description for the functions:
Personally, I think the best would be to use the JOSS paper as the main reference to the package without going into the details of the implementation of the API and allowing users to get the explicit details from the package website and documentation. |
@fboehm WRT this last point about the functionality of the package, we went back to the manuscript and try to add a few more sentences detailing some of the functionalities at a very "high" level (end of the "Functionalities and Main Features" section). Please let us know what do you think. |
@whedon generate pdf from branch literature |
|
@whedon accept from branch literature |
|
Merged! Many thanks for the thorough review and suggestions/edits. |
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2178 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2178, then you can now move forward with accepting the submission by compiling again with the flag
|
Re ihaka:1996, you didn't change the tag to doi - it's still url |
Strange, this was done in this commit and the actual version in the repo, https://github.com/mponce0/covid19.analytics/blob/literature/JOSS/references.bib shows the change... |
I see the |
So sorry, I missed that.. should be fixed now. |
@whedon accept from branch literature |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2179 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2179, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true from branch literature |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @mponce0 (Marcelo Ponce) and co-author! And thanks to @LogIN- and @JDRomano2 for reviewing, and @fboehm for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you very much to you all: @JDRomano2 @danielskatz @LogIN- @fboehm |
Submitting author: @mponce0 (Marcelo Ponce)
Repository: https://github.com/mponce0/covid19.analytics/
Version: 2.1.0
Editor: @fboehm
Reviewer: @LogIN-, @JDRomano2
Archive: 10.5281/zenodo.4640307
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@LogIN- & @JDRomano2, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fboehm know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @LogIN-
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @JDRomano2
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: