-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: ‘Bioassays’; a new package in R for analyzing cellular assays #2402
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @tomsing1 it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
PDF failed to compile for issue #2402 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in |
@anwarbio - your paper title needs quoting, i.e. change this:
to this:
in your |
@arfon - The above change is made in the |
@whedon generate pdf |
@whedon, @arfon |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
Thanks, @anwarbio. |
@whedon remove homoneclocom as reviewer |
OK, homoneclocom is no longer a reviewer |
@whedon add @homonecloco as reviewer |
OK, @homonecloco is now a reviewer |
@fboehm I think I waited too long to accept the https://github.com/openjournals/joss-reviews/invitations invite. Would you mind refreshing it so I can edit the checklist? Many thanks! |
OK, the reviewer has been re-invited. @tomsing1 please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
Hi @anwarbio ,
|
Hi @homonecloco Thank you for reviewing the package and your suggestions are really helpful in improving the package. I have made the below changes in github files. Once all are happy with contents, then I can go for an update on CRAN with all changes.
Thanking you, |
Hi @anwarbio , |
Hi @homonecloco , |
@tomsing1 and @homonecloco - I hope that your reviews are going well. Please feel free to complete the checklists when you're satisfied with the submission and to suggest revisions until you're satisfied. Please let me know how I might help. |
@whedon generate pdf |
@whedon generate pdf |
@anwarbio - the figure labels for the 384-well plate figures should be fixed. Right now, the horizontal axis labels overlap each other. Can you fix this so that the labels are spaced apart a little more? Thanks again! |
@fboehm - Figures are now corrected. Thanks |
@whedon generate pdf |
@anwarbio - the reviewers have recommended your submission for publication. Before we accept it, I need you to make an archive and a Github tagged release. Once you do that, please comment here with the doi of the archive and the version number for the tagged release. Please double-check that the archive has the same author and same title as your submission. |
@fboehm - Thank you very much for the wonderful review and accepting the paper for publication. The doi and version number is given below. Thanks, |
@whedon set 10.5281/zenodo.4075110 as archive |
OK. 10.5281/zenodo.4075110 is the archive. |
@whedon set v1.0.1 as version |
OK. v1.0.1 is the version. |
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1795 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1795, then you can now move forward with accepting the submission by compiling again with the flag
|
Ok I can take over from here! I see that the version and Zenodo archive are taken care of! Paper looks good too. We can move forward. |
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @anwarbio! Thanks to editor @fboehm and reviewers @tomsing1 and @homonecloco for your time and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @anwarbio (ANWAR PALAKKAN)
Repository: https://github.com/anwarbio/bioassays
Version: v1.0.1
Editor: @fboehm
Reviewers: @tomsing1, @homonecloco
Archive: 10.5281/zenodo.4075110
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@tomsing1, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fboehm know.
✨ Please try and complete your review in the next six weeks ✨
Review checklist for @tomsing1
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The vignettes needed proofreading. I have suggested changes and submitted a pull request for the author to review. (I also included a few other minor suggestions in the pull request, which he might find useful.)
Review checklist for @homonecloco
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: