Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JULONG handling to set stackdepth value #630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RoiSoleil
Copy link
Contributor

@RoiSoleil RoiSoleil commented Mar 3, 2025

Fix JULONG handling to set stackdepth value


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Error

 ⚠️ The pull request body must not be empty.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630
$ git checkout pull/630

Update a local copy of the PR:
$ git checkout pull/630
$ git pull https://git.openjdk.org/jmc.git pull/630/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 630

View PR using the GUI difftool:
$ git pr show -t 630

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/630.diff


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/630/head:pull/630
$ git checkout pull/630

Update a local copy of the PR:
$ git checkout pull/630
$ git pull https://git.openjdk.org/jmc.git pull/630/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 630

View PR using the GUI difftool:
$ git pr show -t 630

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/630.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2025

👋 Welcome back RoiSoleil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@RoiSoleil
Copy link
Contributor Author

@skarsaune Could you create an issue for that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant